New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: notify about the redundancy of "nosign" #11119

Merged
merged 1 commit into from Feb 3, 2017

Conversation

Projects
None yet
6 participants
@seishun
Member

seishun commented Feb 2, 2017

vcbuild doesn't sign by default since 92ed1ab, but there might be people who haven't noticed the change. This adds a message informing them that "nosign" is no longer necessary.

Checklist
  • commit message follows commit guidelines
Affected core subsystem(s)

build

build: notify about the redundancy of "nosign"
vcbuild doesn't sign by default since
92ed1ab, but there might be people who
haven't noticed the change. This adds a message informing them that
"nosign" is no longer necessary.

@seishun seishun added the windows label Feb 2, 2017

@cjihrig

cjihrig approved these changes Feb 2, 2017

@jasnell

jasnell approved these changes Feb 2, 2017

@seishun seishun merged commit 7cd6a7d into nodejs:master Feb 3, 2017

@italoacasas

This comment has been minimized.

Show comment
Hide comment
@italoacasas

italoacasas Feb 4, 2017

Member

@seishun This is not landing in v7.x-staging, can you do a backport?

Member

italoacasas commented Feb 4, 2017

@seishun This is not landing in v7.x-staging, can you do a backport?

@seishun

This comment has been minimized.

Show comment
Hide comment
@seishun

seishun Feb 4, 2017

Member

@italoacasas
I'm guessing 99% of vcbuild usage is building master. I don't think adding this notification to other branches is worthwhile.

Member

seishun commented Feb 4, 2017

@italoacasas
I'm guessing 99% of vcbuild usage is building master. I don't think adding this notification to other branches is worthwhile.

@italoacasas

This comment has been minimized.

Show comment
Hide comment
@italoacasas

italoacasas Feb 5, 2017

Member

Thanks. Adding don't-land label.

Member

italoacasas commented Feb 5, 2017

Thanks. Adding don't-land label.

KryDos added a commit to KryDos/node that referenced this pull request Feb 25, 2017

build: notify about the redundancy of "nosign"
vcbuild doesn't sign by default since
92ed1ab, but there might be people who
haven't noticed the change. This adds a message informing them that
"nosign" is no longer necessary.

PR-URL: nodejs#11119
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>

@jasnell jasnell referenced this pull request Apr 4, 2017

Closed

8.0.0 Release Proposal #12220

@seishun seishun deleted the seishun:deprecate-nosign branch Oct 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment