test: simplify output handling in repl tests #11124

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
5 participants
@Trott
Member

Trott commented Feb 2, 2017

Replace .map() + .replace().trim() with a single .replace().

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test repl

test: simplify output handling in repl tests
Replace .map() + .replace().trim() with a single .replace().

@Trott Trott added repl test labels Feb 2, 2017

@Trott

This comment has been minimized.

Show comment
Hide comment
@cjihrig

cjihrig approved these changes Feb 2, 2017

@jasnell

jasnell approved these changes Feb 2, 2017

@hiroppy

hiroppy approved these changes Feb 3, 2017

@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott

Trott Feb 5, 2017

Member

Landed in 950ef82

Member

Trott commented Feb 5, 2017

Landed in 950ef82

@Trott Trott closed this Feb 5, 2017

Trott added a commit to Trott/io.js that referenced this pull request Feb 5, 2017

test: simplify output handling in repl tests
Replace .map() + .replace().trim() with a single .replace().

PR-URL: nodejs#11124
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>

italoacasas added a commit that referenced this pull request Feb 6, 2017

test: simplify output handling in repl tests
Replace .map() + .replace().trim() with a single .replace().

PR-URL: #11124
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>

italoacasas added a commit to italoacasas/node that referenced this pull request Feb 14, 2017

test: simplify output handling in repl tests
Replace .map() + .replace().trim() with a single .replace().

PR-URL: nodejs#11124
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>

KryDos added a commit to KryDos/node that referenced this pull request Feb 25, 2017

test: simplify output handling in repl tests
Replace .map() + .replace().trim() with a single .replace().

PR-URL: nodejs#11124
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Mar 7, 2017

Member

would need a backport PR to land in v4

Member

jasnell commented Mar 7, 2017

would need a backport PR to land in v4

jasnell added a commit that referenced this pull request Mar 7, 2017

test: simplify output handling in repl tests
Replace .map() + .replace().trim() with a single .replace().

PR-URL: #11124
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>

MylesBorins added a commit that referenced this pull request Mar 9, 2017

test: simplify output handling in repl tests
Replace .map() + .replace().trim() with a single .replace().

PR-URL: #11124
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>

@MylesBorins MylesBorins referenced this pull request Mar 9, 2017

Merged

v6.10.1 proposal #11759

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment