test: improve events coverage to check removeListeners functions #11140

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
7 participants
@cauchym

cauchym commented Feb 3, 2017

I improved test coverage for events. I found removeListerers , removeAllListerers tests. However remove(All)Listener(s) function does not pass some points. This PR will improve coverage.

I found this commit, but it seems to need to add tests when _events is undefined.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

N/A

@hiroppy hiroppy added the events label Feb 3, 2017

@cjihrig

cjihrig approved these changes Feb 3, 2017

@jasnell

jasnell approved these changes Feb 3, 2017

@mhdawson

LGTM

jasnell added a commit that referenced this pull request Feb 3, 2017

test: improve coverage on removeListeners functions
PR-URL: #11140
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Feb 3, 2017

Member

Landed in 7d2dc90

Member

jasnell commented Feb 3, 2017

Landed in 7d2dc90

@jasnell jasnell closed this Feb 3, 2017

italoacasas added a commit to italoacasas/node that referenced this pull request Feb 4, 2017

test: improve coverage on removeListeners functions
PR-URL: nodejs#11140
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

italoacasas added a commit to italoacasas/node that referenced this pull request Feb 14, 2017

test: improve coverage on removeListeners functions
PR-URL: nodejs#11140
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

KryDos added a commit to KryDos/node that referenced this pull request Feb 25, 2017

test: improve coverage on removeListeners functions
PR-URL: nodejs#11140
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

jasnell added a commit that referenced this pull request Mar 7, 2017

test: improve coverage on removeListeners functions
PR-URL: #11140
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

jasnell added a commit that referenced this pull request Mar 7, 2017

test: improve coverage on removeListeners functions
PR-URL: #11140
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

MylesBorins added a commit that referenced this pull request Mar 9, 2017

test: improve coverage on removeListeners functions
PR-URL: #11140
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

@MylesBorins MylesBorins referenced this pull request Mar 9, 2017

Merged

v6.10.1 proposal #11759

MylesBorins added a commit that referenced this pull request Mar 9, 2017

test: improve coverage on removeListeners functions
PR-URL: #11140
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

@MylesBorins MylesBorins referenced this pull request Mar 9, 2017

Merged

v4.8.1 proposal #11760

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment