Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
src: fix building --without-v8-platform (backport v7.x) #11157
Affected core subsystem(s)
Backport of the relevant commit from #11088 to v7.x-staging.
The call signature of v8_platform.StartInspector needs to be the same
(cherry picked from commit e619725)
changed the title from
Fix without v8 platform (backport v7.x)
src: fix building --without-v8-platform (backport v7.x)
Feb 4, 2017
Right, I see
Indeed, the Mac build reports a java.lang.NullPointerException at java.util.HashSet.(HashSet.java:118) both for this PR's build and for previous ones (f.e. the previous build https://ci.nodejs.org/job/node-test-commit-osx/7642/). So that's an issue with the CI service, not this PR.
Erm, I'm unsure of next steps here (first time Node.js bug fixer). I don't see issues on the CI service itself in this repository's issue tracker. Is there another place I should file those?