New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: typographical fixes in COLLABORATOR_GUIDE.md #11163

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
5 participants
@addaleax
Member

addaleax commented Feb 4, 2017

Fix a typo and add a missing line break.

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
doc: typographical fixes in COLLABORATOR_GUIDE.md
Fix a typo and add a missing line break.

@addaleax addaleax added the doc label Feb 4, 2017

@mscdex mscdex added the meta label Feb 4, 2017

@seishun

seishun approved these changes Feb 4, 2017

@addaleax

This comment has been minimized.

Show comment
Hide comment
@addaleax

addaleax Feb 4, 2017

Member

I feel fairly comfortable calling this a “trivial change” ;)

Landed in 0101d77, thanks for the quick reviews.

Member

addaleax commented Feb 4, 2017

I feel fairly comfortable calling this a “trivial change” ;)

Landed in 0101d77, thanks for the quick reviews.

@addaleax addaleax closed this Feb 4, 2017

@addaleax addaleax deleted the addaleax:collab-guide-typos branch Feb 4, 2017

addaleax added a commit that referenced this pull request Feb 4, 2017

doc: typographical fixes in COLLABORATOR_GUIDE.md
Fix a typo and add a missing line break.

PR-URL: #11163
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

italoacasas added a commit to italoacasas/node that referenced this pull request Feb 5, 2017

doc: typographical fixes in COLLABORATOR_GUIDE.md
Fix a typo and add a missing line break.

PR-URL: nodejs#11163
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

italoacasas added a commit to italoacasas/node that referenced this pull request Feb 14, 2017

doc: typographical fixes in COLLABORATOR_GUIDE.md
Fix a typo and add a missing line break.

PR-URL: nodejs#11163
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

KryDos added a commit to KryDos/node that referenced this pull request Feb 25, 2017

doc: typographical fixes in COLLABORATOR_GUIDE.md
Fix a typo and add a missing line break.

PR-URL: nodejs#11163
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

jasnell added a commit that referenced this pull request Mar 7, 2017

doc: typographical fixes in COLLABORATOR_GUIDE.md
Fix a typo and add a missing line break.

PR-URL: #11163
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

jasnell added a commit that referenced this pull request Mar 7, 2017

doc: typographical fixes in COLLABORATOR_GUIDE.md
Fix a typo and add a missing line break.

PR-URL: #11163
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

MylesBorins added a commit that referenced this pull request Mar 9, 2017

doc: typographical fixes in COLLABORATOR_GUIDE.md
Fix a typo and add a missing line break.

PR-URL: #11163
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

@MylesBorins MylesBorins referenced this pull request Mar 9, 2017

Merged

v6.10.1 proposal #11759

MylesBorins added a commit that referenced this pull request Mar 9, 2017

doc: typographical fixes in COLLABORATOR_GUIDE.md
Fix a typo and add a missing line break.

PR-URL: #11163
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

@MylesBorins MylesBorins referenced this pull request Mar 9, 2017

Merged

v4.8.1 proposal #11760

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment