src: fix -Wunused-result compiler warning #11197

Merged
merged 1 commit into from Feb 9, 2017

Conversation

Projects
None yet
7 participants
@bnoordhuis
Member

bnoordhuis commented Feb 6, 2017

Fix a warning that was introduced in commit 67af1ad ("src: refactor
CopyProperties to remove JS") from a few days ago. This particular
change was suggested by me, mea culpa.

Fixes the following warning:

../src/node_contextify.cc:151:13: warning: ignoring return
value of function declared with warn_unused_result attribute
[-Wunused-result]
            sandbox_obj->DefineProperty(context, key, *desc);

CI: https://ci.nodejs.org/job/node-test-pull-request/6233/

@danbev

danbev approved these changes Feb 6, 2017

@jasnell

jasnell approved these changes Feb 6, 2017

@mhdawson

LGTM

src: fix -Wunused-result compiler warning
Fix a warning that was introduced in commit 67af1ad ("src: refactor
CopyProperties to remove JS") from a few days ago.  This particular
change was suggested by me, mea culpa.

Fixes the following warning:

    ../src/node_contextify.cc:151:13: warning: ignoring return
    value of function declared with warn_unused_result attribute
    [-Wunused-result]
                sandbox_obj->DefineProperty(context, key, *desc);

PR-URL: #11197
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

@bnoordhuis bnoordhuis closed this Feb 9, 2017

@bnoordhuis bnoordhuis deleted the bnoordhuis:fix-build-warning branch Feb 9, 2017

@bnoordhuis bnoordhuis merged commit 215a649 into nodejs:master Feb 9, 2017

@bnoordhuis

This comment has been minimized.

Show comment
Hide comment
@bnoordhuis

bnoordhuis Feb 9, 2017

Member

Sorry, final commit is 6af0bfe. I overlooked Daniel's LGTM.

Member

bnoordhuis commented Feb 9, 2017

Sorry, final commit is 6af0bfe. I overlooked Daniel's LGTM.

bnoordhuis added a commit that referenced this pull request Feb 9, 2017

src: fix -Wunused-result compiler warning
Fix a warning that was introduced in commit 67af1ad ("src: refactor
CopyProperties to remove JS") from a few days ago.  This particular
change was suggested by me, mea culpa.

Fixes the following warning:

    ../src/node_contextify.cc:151:13: warning: ignoring return
    value of function declared with warn_unused_result attribute
    [-Wunused-result]
                sandbox_obj->DefineProperty(context, key, *desc);

PR-URL: #11197
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@italoacasas

This comment has been minimized.

Show comment
Hide comment
@italoacasas

italoacasas Feb 9, 2017

Member

This is not landing clearly in v7.x-staging, any plan to backport?

Member

italoacasas commented Feb 9, 2017

This is not landing clearly in v7.x-staging, any plan to backport?

@bnoordhuis

This comment has been minimized.

Show comment
Hide comment
@bnoordhuis

bnoordhuis Feb 9, 2017

Member

It's dependent on #11102 and that's tagged with dont-land labels. I'll add them here as well.

Member

bnoordhuis commented Feb 9, 2017

It's dependent on #11102 and that's tagged with dont-land labels. I'll add them here as well.

@italoacasas

This comment has been minimized.

Show comment
Hide comment
@italoacasas

italoacasas Feb 9, 2017

Member

I'm going to backport #11102 since that version of v8 is already on staging

I land #11102 already in staging

Member

italoacasas commented Feb 9, 2017

I'm going to backport #11102 since that version of v8 is already on staging

I land #11102 already in staging

@bnoordhuis

This comment has been minimized.

Show comment
Hide comment
@bnoordhuis

bnoordhuis Feb 10, 2017

Member

@italoacasas Then this PR should merge cleanly now.

Member

bnoordhuis commented Feb 10, 2017

@italoacasas Then this PR should merge cleanly now.

italoacasas added a commit that referenced this pull request Feb 13, 2017

src: fix -Wunused-result compiler warning
Fix a warning that was introduced in commit 67af1ad ("src: refactor
CopyProperties to remove JS") from a few days ago.  This particular
change was suggested by me, mea culpa.

Fixes the following warning:

    ../src/node_contextify.cc:151:13: warning: ignoring return
    value of function declared with warn_unused_result attribute
    [-Wunused-result]
                sandbox_obj->DefineProperty(context, key, *desc);

PR-URL: #11197
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

italoacasas added a commit to italoacasas/node that referenced this pull request Feb 14, 2017

src: fix -Wunused-result compiler warning
Fix a warning that was introduced in commit 67af1ad ("src: refactor
CopyProperties to remove JS") from a few days ago.  This particular
change was suggested by me, mea culpa.

Fixes the following warning:

    ../src/node_contextify.cc:151:13: warning: ignoring return
    value of function declared with warn_unused_result attribute
    [-Wunused-result]
                sandbox_obj->DefineProperty(context, key, *desc);

PR-URL: nodejs#11197
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

KryDos added a commit to KryDos/node that referenced this pull request Feb 25, 2017

src: fix -Wunused-result compiler warning
Fix a warning that was introduced in commit 67af1ad ("src: refactor
CopyProperties to remove JS") from a few days ago.  This particular
change was suggested by me, mea culpa.

Fixes the following warning:

    ../src/node_contextify.cc:151:13: warning: ignoring return
    value of function declared with warn_unused_result attribute
    [-Wunused-result]
                sandbox_obj->DefineProperty(context, key, *desc);

PR-URL: nodejs#11197
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment