New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: back-port b049d1a from V8 upstream #11204

Merged
merged 1 commit into from Feb 9, 2017

Conversation

Projects
None yet
4 participants
@bnoordhuis
Member

bnoordhuis commented Feb 6, 2017

Original commit message:

Ensure we align zone memory at 8 byte boundaries on all platforms

BUG=v8:5668
R=verwaest@chromium.org

Review-Url: https://codereview.chromium.org/2672203002

CI: https://ci.nodejs.org/job/node-test-pull-request/6245/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/557/

@bnoordhuis

This comment has been minimized.

Show comment
Hide comment
@bnoordhuis

bnoordhuis Feb 6, 2017

Member

@nodejs/v8 I'm quietly hopeful this commit will fix some of the bug reports we've received about mksnapshot dying with SIGBUS on ARM and MIPS.

Member

bnoordhuis commented Feb 6, 2017

@nodejs/v8 I'm quietly hopeful this commit will fix some of the bug reports we've received about mksnapshot dying with SIGBUS on ARM and MIPS.

@jasnell

jasnell approved these changes Feb 6, 2017

rubber stamp lgtm

@ofrobots

LGTM. Can you request upstream backports to 5.6 and 5.7 as well?

deps: back-port b049d1a from V8 upstream
Original commit message:

    Ensure we align zone memory at 8 byte boundaries on all platforms

    BUG=v8:5668
    R=verwaest@chromium.org

    Review-Url: https://codereview.chromium.org/2672203002
    Cr-Commit-Position: refs/heads/master@{#42959}

PR-URL: #11204
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@bnoordhuis bnoordhuis closed this Feb 9, 2017

@bnoordhuis bnoordhuis deleted the bnoordhuis:v8-backport-b049d1a branch Feb 9, 2017

@bnoordhuis bnoordhuis merged commit 039a813 into nodejs:master Feb 9, 2017

@bnoordhuis

This comment has been minimized.

Show comment
Hide comment
@bnoordhuis

bnoordhuis Feb 9, 2017

Member

Can you request upstream backports to 5.6 and 5.7 as well?

Done: https://bugs.chromium.org/p/v8/issues/detail?id=5668#c8

Member

bnoordhuis commented Feb 9, 2017

Can you request upstream backports to 5.6 and 5.7 as well?

Done: https://bugs.chromium.org/p/v8/issues/detail?id=5668#c8

italoacasas added a commit to italoacasas/node that referenced this pull request Feb 9, 2017

deps: back-port b049d1a from V8 upstream
Original commit message:

    Ensure we align zone memory at 8 byte boundaries on all platforms

    BUG=v8:5668
    R=verwaest@chromium.org

    Review-Url: https://codereview.chromium.org/2672203002
    Cr-Commit-Position: refs/heads/master@{#42959}

PR-URL: nodejs#11204
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

italoacasas added a commit to italoacasas/node that referenced this pull request Feb 14, 2017

deps: back-port b049d1a from V8 upstream
Original commit message:

    Ensure we align zone memory at 8 byte boundaries on all platforms

    BUG=v8:5668
    R=verwaest@chromium.org

    Review-Url: https://codereview.chromium.org/2672203002
    Cr-Commit-Position: refs/heads/master@{#42959}

PR-URL: nodejs#11204
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

KryDos added a commit to KryDos/node that referenced this pull request Feb 25, 2017

deps: back-port b049d1a from V8 upstream
Original commit message:

    Ensure we align zone memory at 8 byte boundaries on all platforms

    BUG=v8:5668
    R=verwaest@chromium.org

    Review-Url: https://codereview.chromium.org/2672203002
    Cr-Commit-Position: refs/heads/master@{#42959}

PR-URL: nodejs#11204
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Mar 7, 2017

Member

backport PRs would be needed to land this in v6 or v4 (if appropriate for either)

Member

jasnell commented Mar 7, 2017

backport PRs would be needed to land this in v6 or v4 (if appropriate for either)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment