New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: edit maxBuffer/Unicode paragraph for clarity #11228

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
4 participants
@Trott
Member

Trott commented Feb 7, 2017

Remove unneeded words from child_process doc.

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc child_process

doc: edit maxBuffer/Unicode paragraph for clarity
Remove unneeded words from child_process doc.
@jasnell

jasnell approved these changes Feb 7, 2017

Show outdated Hide outdated doc/api/child_process.md
```js
console.log('中文测试');
```
The `maxBuffer` option specifies the largest number of *octets* allowed on

This comment has been minimized.

@cjihrig

cjihrig Feb 7, 2017

Contributor

Would you mind replacing octets with bytes. I think more people would recognize bytes, and it's used throughout this document.

@cjihrig

cjihrig Feb 7, 2017

Contributor

Would you mind replacing octets with bytes. I think more people would recognize bytes, and it's used throughout this document.

@cjihrig

cjihrig approved these changes Feb 7, 2017

@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott

Trott Feb 9, 2017

Member

Landed in a3bc9a1

Member

Trott commented Feb 9, 2017

Landed in a3bc9a1

@Trott Trott closed this Feb 9, 2017

Trott added a commit to Trott/io.js that referenced this pull request Feb 9, 2017

doc: edit maxBuffer/Unicode paragraph for clarity
Remove unneeded words from child_process doc.

PR-URL: nodejs#11228
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

italoacasas added a commit that referenced this pull request Feb 13, 2017

doc: edit maxBuffer/Unicode paragraph for clarity
Remove unneeded words from child_process doc.

PR-URL: #11228
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

italoacasas added a commit to italoacasas/node that referenced this pull request Feb 14, 2017

doc: edit maxBuffer/Unicode paragraph for clarity
Remove unneeded words from child_process doc.

PR-URL: nodejs#11228
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

KryDos added a commit to KryDos/node that referenced this pull request Feb 25, 2017

doc: edit maxBuffer/Unicode paragraph for clarity
Remove unneeded words from child_process doc.

PR-URL: nodejs#11228
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

jasnell added a commit that referenced this pull request Mar 7, 2017

doc: edit maxBuffer/Unicode paragraph for clarity
Remove unneeded words from child_process doc.

PR-URL: #11228
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Mar 7, 2017

Member

would need a backport PR to land on v4

Member

jasnell commented Mar 7, 2017

would need a backport PR to land on v4

MylesBorins added a commit that referenced this pull request Mar 9, 2017

doc: edit maxBuffer/Unicode paragraph for clarity
Remove unneeded words from child_process doc.

PR-URL: #11228
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

@MylesBorins MylesBorins referenced this pull request Mar 9, 2017

Merged

v6.10.1 proposal #11759

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment