New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: increase dgram ref()/unref() coverage #11240

Merged
merged 1 commit into from Feb 10, 2017

Conversation

Projects
None yet
5 participants
@cjihrig
Contributor

cjihrig commented Feb 8, 2017

This commit completes code coverage for dgram's Socket#ref() and Socket#unref() methods.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@mscdex mscdex added the dgram label Feb 8, 2017

@cjihrig

This comment has been minimized.

Show comment
Hide comment
Contributor

cjihrig commented Feb 10, 2017

{
// Test the case of unref()'ing a socket with a handle.
const s = dgram.createSocket('udp4');
s.bind();

This comment has been minimized.

@santigimeno

santigimeno Feb 10, 2017

Member

Is the call to bind() necessary?

@santigimeno

santigimeno Feb 10, 2017

Member

Is the call to bind() necessary?

This comment has been minimized.

@cjihrig

cjihrig Feb 10, 2017

Contributor

The test will run without the bind(), but binding keeps the event loop open and causes the test to timeout if unref'ing doesn't actually work.

@cjihrig

cjihrig Feb 10, 2017

Contributor

The test will run without the bind(), but binding keeps the event loop open and causes the test to timeout if unref'ing doesn't actually work.

This comment has been minimized.

@santigimeno

santigimeno Feb 10, 2017

Member

Got it. Thanks!

@santigimeno

santigimeno Feb 10, 2017

Member

Got it. Thanks!

@santigimeno

LGTM with a question?

@cjihrig

This comment has been minimized.

Show comment
Hide comment
test: increase dgram ref()/unref() coverage
This commit completes code coverage for dgram's Socket#ref() and
Socket#unref() methods.

PR-URL: #11240
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@cjihrig cjihrig merged commit b471392 into nodejs:master Feb 10, 2017

@cjihrig cjihrig deleted the cjihrig:ref-unref branch Feb 10, 2017

italoacasas added a commit that referenced this pull request Feb 13, 2017

test: increase dgram ref()/unref() coverage
This commit completes code coverage for dgram's Socket#ref() and
Socket#unref() methods.

PR-URL: #11240
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

italoacasas added a commit to italoacasas/node that referenced this pull request Feb 14, 2017

test: increase dgram ref()/unref() coverage
This commit completes code coverage for dgram's Socket#ref() and
Socket#unref() methods.

PR-URL: nodejs#11240
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

KryDos added a commit to KryDos/node that referenced this pull request Feb 25, 2017

test: increase dgram ref()/unref() coverage
This commit completes code coverage for dgram's Socket#ref() and
Socket#unref() methods.

PR-URL: nodejs#11240
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Mar 8, 2017

Member

Landing on v6. Needs a backport PR if it should land on v4

Member

jasnell commented Mar 8, 2017

Landing on v6. Needs a backport PR if it should land on v4

jasnell added a commit that referenced this pull request Mar 8, 2017

test: increase dgram ref()/unref() coverage
This commit completes code coverage for dgram's Socket#ref() and
Socket#unref() methods.

PR-URL: #11240
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added a commit that referenced this pull request Mar 9, 2017

test: increase dgram ref()/unref() coverage
This commit completes code coverage for dgram's Socket#ref() and
Socket#unref() methods.

PR-URL: #11240
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@MylesBorins MylesBorins referenced this pull request Mar 9, 2017

Merged

v6.10.1 proposal #11759

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment