New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add coverage to dgram receive error case #11241

Merged
merged 1 commit into from Feb 10, 2017

Conversation

Projects
None yet
5 participants
@cjihrig
Contributor

cjihrig commented Feb 8, 2017

This commit adds coverage for the case where a dgram socket
handle receives a message, but nread < 0, indicating an error.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@jasnell

jasnell approved these changes Feb 8, 2017

@mscdex mscdex added the dgram label Feb 8, 2017

@hiroppy

hiroppy approved these changes Feb 9, 2017

@hiroppy

This comment has been minimized.

Show comment
Hide comment
test: add coverage to dgram receive error case
This commit adds coverage for the case where a dgram socket
handle receives a message, but nread < 0, indicating an error.

PR-URL: #11241
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>

@cjihrig cjihrig merged commit 1683299 into nodejs:master Feb 10, 2017

@cjihrig cjihrig deleted the cjihrig:recv-err branch Feb 10, 2017

italoacasas added a commit that referenced this pull request Feb 13, 2017

test: add coverage to dgram receive error case
This commit adds coverage for the case where a dgram socket
handle receives a message, but nread < 0, indicating an error.

PR-URL: #11241
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>

italoacasas added a commit to italoacasas/node that referenced this pull request Feb 14, 2017

test: add coverage to dgram receive error case
This commit adds coverage for the case where a dgram socket
handle receives a message, but nread < 0, indicating an error.

PR-URL: nodejs#11241
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>

KryDos added a commit to KryDos/node that referenced this pull request Feb 25, 2017

test: add coverage to dgram receive error case
This commit adds coverage for the case where a dgram socket
handle receives a message, but nread < 0, indicating an error.

PR-URL: nodejs#11241
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Mar 8, 2017

Member

Depends on common.mustNotCall() to be backported.

Member

jasnell commented Mar 8, 2017

Depends on common.mustNotCall() to be backported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment