dgram: remove this aliases #11243

Merged
merged 1 commit into from Feb 10, 2017

Conversation

Projects
None yet
4 participants
@cjihrig
Contributor

cjihrig commented Feb 8, 2017

This commit removes self = this style assignments from dgram.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

dgram

@targos

targos approved these changes Feb 8, 2017

@jasnell

jasnell approved these changes Feb 8, 2017

@cjihrig

This comment has been minimized.

Show comment
Hide comment
dgram: remove this aliases
This commit removes self = this style assignments from dgram.

PR-URL: #11243
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@cjihrig cjihrig merged commit b594b3b into nodejs:master Feb 10, 2017

@cjihrig cjihrig deleted the cjihrig:no-self branch Feb 10, 2017

@vsemozhetbyt vsemozhetbyt referenced this pull request Feb 10, 2017

Closed

dgram: fix possibly deoptimizing use of arguments #11242

2 of 2 tasks complete

italoacasas added a commit that referenced this pull request Feb 13, 2017

dgram: remove this aliases
This commit removes self = this style assignments from dgram.

PR-URL: #11243
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

italoacasas added a commit to italoacasas/node that referenced this pull request Feb 14, 2017

dgram: remove this aliases
This commit removes self = this style assignments from dgram.

PR-URL: nodejs#11243
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

KryDos added a commit to KryDos/node that referenced this pull request Feb 25, 2017

dgram: remove this aliases
This commit removes self = this style assignments from dgram.

PR-URL: nodejs#11243
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

jasnell added a commit that referenced this pull request Mar 8, 2017

dgram: remove this aliases
This commit removes self = this style assignments from dgram.

PR-URL: #11243
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Mar 8, 2017

Member

Landed on v6. Needs a backport if it should land on v4

Member

jasnell commented Mar 8, 2017

Landed on v6. Needs a backport if it should land on v4

MylesBorins added a commit that referenced this pull request Mar 9, 2017

dgram: remove this aliases
This commit removes self = this style assignments from dgram.

PR-URL: #11243
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@MylesBorins MylesBorins referenced this pull request Mar 9, 2017

Merged

v6.10.1 proposal #11759

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment