Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
build: clear stalled jobs on POSIX CI hosts #11246
Sometimes, after a cluster or debug test fails, a fixture hangs around
Affected core subsystem(s)
changed the title from
WIP: build: clear stalled jobs on POSIX CI hosts
build: clear stalled jobs on POSIX CI hosts
Feb 8, 2017
If the target is declared phony, I'm not sure that it matters if it is order-only or not as a prerequisite.
Related to nodejs/build#591
As discussed in that issue, I'd rather have something in the test runner that kept track of processes that hadn't been cleaned up at the end of each run, and failed the job if there were any. However I do think this is better than what we currently have (later jobs randomly failing and
Currently I don't think this is logging what processes it is cleaning up though, which is information I do think we need, so I'd be -1 on this without that.
I'm also not sure under what circumstances processes get left behind, doesn't tools/test.py clean up once the TIMEOUT happens? I assumed it was for orphaned node subprocesses, but I'm not sure.
I agree on this. If a test is leaving processes behind I think it should fail.
I also agree on this.
@santigimeno So with the latest update this will now list the processes it's killing, so I'd say this is an improvement over what we currently do. Are you -1 on this landing as a step in the right direction?
If we could fix
Sorry, I had overlooked the