test: add coverage for string array dgram send() #11247

Merged
merged 1 commit into from Feb 10, 2017

Conversation

Projects
None yet
6 participants
@cjihrig
Contributor

cjihrig commented Feb 8, 2017

This commit adds code coverage for dgram's Socket#send() where the data is an array of strings.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@mscdex mscdex added the dgram label Feb 8, 2017

@hiroppy

hiroppy approved these changes Feb 9, 2017

@jasnell

LGTM but I'm curious: do we / should we test arrays of other data types also?

@jasnell

jasnell approved these changes Feb 9, 2017

@cjihrig

This comment has been minimized.

Show comment
Hide comment
@cjihrig

cjihrig Feb 9, 2017

Contributor

do we / should we test arrays of other data types also?

Yea, that code is already covered.

Contributor

cjihrig commented Feb 9, 2017

do we / should we test arrays of other data types also?

Yea, that code is already covered.

@cjihrig

This comment has been minimized.

Show comment
Hide comment
@mhdawson

LGTM

test: add coverage for string array dgram send()
This commit adds code coverage for dgram's Socket#send() where
the data is an array of strings.

PR-URL: #11247
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

@cjihrig cjihrig merged commit df14956 into nodejs:master Feb 10, 2017

@cjihrig cjihrig deleted the cjihrig:string-array branch Feb 10, 2017

italoacasas added a commit that referenced this pull request Feb 13, 2017

test: add coverage for string array dgram send()
This commit adds code coverage for dgram's Socket#send() where
the data is an array of strings.

PR-URL: #11247
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

italoacasas added a commit to italoacasas/node that referenced this pull request Feb 14, 2017

test: add coverage for string array dgram send()
This commit adds code coverage for dgram's Socket#send() where
the data is an array of strings.

PR-URL: nodejs#11247
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

KryDos added a commit to KryDos/node that referenced this pull request Feb 25, 2017

test: add coverage for string array dgram send()
This commit adds code coverage for dgram's Socket#send() where
the data is an array of strings.

PR-URL: nodejs#11247
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

jasnell added a commit that referenced this pull request Mar 7, 2017

test: add coverage for string array dgram send()
This commit adds code coverage for dgram's Socket#send() where
the data is an array of strings.

PR-URL: #11247
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

MylesBorins added a commit that referenced this pull request Mar 9, 2017

test: add coverage for string array dgram send()
This commit adds code coverage for dgram's Socket#send() where
the data is an array of strings.

PR-URL: #11247
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

@MylesBorins MylesBorins referenced this pull request Mar 9, 2017

Merged

v6.10.1 proposal #11759

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment