test: qs.escape with multibyte characters under 0x800 #11251

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
5 participants
@watilde
Member

watilde commented Feb 9, 2017

Improve test coverage of querystring:

This test case will cover these lines:

  • node/lib/querystring.js

    Lines 169 to 173 in fcedd71

    if (c < 0x800) {
    lastPos = i + 1;
    out += hexTable[0xC0 | (c >> 6)] + hexTable[0x80 | (c & 0x3F)];
    continue;
    }
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@bnoordhuis

LGTM but can you trim the commit log to <= 50 characters? Thanks.

CI: https://ci.nodejs.org/job/node-test-pull-request/6307/

test: querystring.escape with multibyte characters
Add a test case for querystring.parse with multibyte characters
under 0x800.

PR-URL: #11251
@watilde

This comment has been minimized.

Show comment
Hide comment
@watilde

watilde Feb 9, 2017

Member

@bnoordhuis Sure thing! Done :)

Member

watilde commented Feb 9, 2017

@bnoordhuis Sure thing! Done :)

@jasnell

jasnell approved these changes Feb 9, 2017

jasnell added a commit that referenced this pull request Feb 11, 2017

test: querystring.escape with multibyte characters
Add a test case for querystring.parse with multibyte characters
under 0x800.

PR-URL: #11251
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Feb 11, 2017

Member

Landed in 81ef56b

Member

jasnell commented Feb 11, 2017

Landed in 81ef56b

@jasnell jasnell closed this Feb 11, 2017

@watilde watilde deleted the watilde:test-qs-escape branch Feb 11, 2017

italoacasas added a commit that referenced this pull request Feb 13, 2017

test: querystring.escape with multibyte characters
Add a test case for querystring.parse with multibyte characters
under 0x800.

PR-URL: #11251
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>

italoacasas added a commit to italoacasas/node that referenced this pull request Feb 14, 2017

test: querystring.escape with multibyte characters
Add a test case for querystring.parse with multibyte characters
under 0x800.

PR-URL: nodejs#11251
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>

KryDos added a commit to KryDos/node that referenced this pull request Feb 25, 2017

test: querystring.escape with multibyte characters
Add a test case for querystring.parse with multibyte characters
under 0x800.

PR-URL: nodejs#11251
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Mar 7, 2017

Member

would need a backport PR to land on v4

Member

jasnell commented Mar 7, 2017

would need a backport PR to land on v4

jasnell added a commit that referenced this pull request Mar 7, 2017

test: querystring.escape with multibyte characters
Add a test case for querystring.parse with multibyte characters
under 0x800.

PR-URL: #11251
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added a commit that referenced this pull request Mar 9, 2017

test: querystring.escape with multibyte characters
Add a test case for querystring.parse with multibyte characters
under 0x800.

PR-URL: #11251
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>

@MylesBorins MylesBorins referenced this pull request Mar 9, 2017

Merged

v6.10.1 proposal #11759

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment