New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: adapt test-debugger-pid to localized Windows #11270

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
@vsemozhetbyt
Member

vsemozhetbyt commented Feb 9, 2017

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test, debugger

Fixes: #11250

@Trott

Trott approved these changes Feb 9, 2017

LGTM if CI is green

@Trott

This comment has been minimized.

Show comment
Hide comment

@Trott Trott added the debugger label Feb 9, 2017

jasnell added a commit that referenced this pull request Feb 11, 2017

test: adapt test-debugger-pid to localized Windows
PR-URL: #11270
Fixes: #11250
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Feb 11, 2017

Member

Landed in a29c85a

Member

jasnell commented Feb 11, 2017

Landed in a29c85a

@jasnell jasnell closed this Feb 11, 2017

@vsemozhetbyt vsemozhetbyt deleted the vsemozhetbyt:test-debugger-pid branch Feb 11, 2017

italoacasas added a commit that referenced this pull request Feb 13, 2017

test: adapt test-debugger-pid to localized Windows
PR-URL: #11270
Fixes: #11250
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

italoacasas added a commit to italoacasas/node that referenced this pull request Feb 14, 2017

test: adapt test-debugger-pid to localized Windows
PR-URL: nodejs#11270
Fixes: nodejs#11250
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

KryDos added a commit to KryDos/node that referenced this pull request Feb 25, 2017

test: adapt test-debugger-pid to localized Windows
PR-URL: nodejs#11270
Fixes: nodejs#11250
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Mar 7, 2017

Member

requires a backport PR in order to land on v4

Member

jasnell commented Mar 7, 2017

requires a backport PR in order to land on v4

jasnell added a commit that referenced this pull request Mar 7, 2017

test: adapt test-debugger-pid to localized Windows
PR-URL: #11270
Fixes: #11250
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added a commit that referenced this pull request Mar 9, 2017

test: adapt test-debugger-pid to localized Windows
PR-URL: #11270
Fixes: #11250
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@MylesBorins MylesBorins referenced this pull request Mar 9, 2017

Merged

v6.10.1 proposal #11759

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment