test: refactor test-dgram-address.js #11271

Merged
merged 1 commit into from Feb 13, 2017

Conversation

Projects
None yet
3 participants
@cjihrig
Contributor

cjihrig commented Feb 9, 2017

  • separate the IPv4 and IPv6 tests using block scopes
  • use common.mustCall() and arrow functions for callbacks
  • add coverage for case where address() throws
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@cjihrig cjihrig added the dgram label Feb 9, 2017

@jasnell

jasnell approved these changes Feb 9, 2017

@cjihrig

This comment has been minimized.

Show comment
Hide comment
test: refactor test-dgram-address.js
- separate the IPv4 and IPv6 tests using block scopes
- use common.mustCall() and arrow functions for callbacks
- add coverage for case where address() throws

PR-URL: #11271
Reviewed-By: James M Snell <jasnell@gmail.com>

@cjihrig cjihrig merged commit 3a1e67d into nodejs:master Feb 13, 2017

@cjihrig cjihrig deleted the cjihrig:address branch Feb 13, 2017

italoacasas added a commit to italoacasas/node that referenced this pull request Feb 14, 2017

test: refactor test-dgram-address.js
- separate the IPv4 and IPv6 tests using block scopes
- use common.mustCall() and arrow functions for callbacks
- add coverage for case where address() throws

PR-URL: nodejs#11271
Reviewed-By: James M Snell <jasnell@gmail.com>

@rvagg rvagg referenced this pull request Feb 16, 2017

Closed

test: skip IPv6 test on non-IPv6 systems #11432

2 of 2 tasks complete
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Mar 9, 2017

Member

Needs backport PRs if it should land on v6 or v4

Member

jasnell commented Mar 9, 2017

Needs backport PRs if it should land on v6 or v4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment