New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark: fix typos #11287

Merged
merged 2 commits into from Feb 10, 2017

Conversation

Projects
None yet
7 participants
@seishun
Member

seishun commented Feb 10, 2017

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

benchmark

@cjihrig

LGTM. You could probably use benchmark as the subsystem.

@hiroppy hiroppy added the doc label Feb 10, 2017

@seishun seishun changed the title from doc: fix typo to benchmark: fix typo Feb 10, 2017

@seishun seishun changed the title from benchmark: fix typo to benchmark: fix typos Feb 10, 2017

@@ -55,8 +55,8 @@ In the event you get a message that you need to select a CRAN mirror first.
You can specify a mirror by adding in the repo parameter.
If we used the "http://cran.us.r-project.org" mirror, it could look somehting like
this:
If we used the "http://cran.us.r-project.org" mirror, it could look something

This comment has been minimized.

@mscdex

mscdex Feb 10, 2017

Contributor

I believe this will be covered by #11189 once that lands.

@mscdex

mscdex Feb 10, 2017

Contributor

I believe this will be covered by #11189 once that lands.

This comment has been minimized.

@seishun

seishun Feb 10, 2017

Member

Yeah but this also fixes the 80-column thing.

@seishun

seishun Feb 10, 2017

Member

Yeah but this also fixes the 80-column thing.

@jasnell

I don't believe this needs to wait the 48 hours to land

@seishun seishun merged commit f5ee992 into nodejs:master Feb 10, 2017

italoacasas added a commit that referenced this pull request Feb 13, 2017

benchmark: fix typos
PR-URL: #11287
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

italoacasas added a commit to italoacasas/node that referenced this pull request Feb 14, 2017

benchmark: fix typos
PR-URL: nodejs#11287
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

KryDos added a commit to KryDos/node that referenced this pull request Feb 25, 2017

benchmark: fix typos
PR-URL: nodejs#11287
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

@seishun seishun deleted the seishun:fix-manger branch Oct 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment