test: cover cluster error during dgram socket bind #11295

Merged
merged 1 commit into from Feb 13, 2017

Conversation

Projects
None yet
4 participants
@cjihrig
Contributor

cjihrig commented Feb 10, 2017

When a non-exclusive dgram socket is bound from a cluster worker, a handle is requested from the cluster module. This commit adds coverage for the case where an error occurs while retrieving the handle.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@mscdex mscdex added the dgram label Feb 10, 2017

@cjihrig

This comment has been minimized.

Show comment
Hide comment
Contributor

cjihrig commented Feb 13, 2017

test: cover cluster error during dgram socket bind
When a non-exclusive dgram socket is bound from a cluster
worker, a handle is requested from the cluster module. This
commit adds coverage for the case where an error occurs while
retrieving the handle.

PR-URL: #11295
Reviewed-By: James M Snell <jasnell@gmail.com>

@cjihrig cjihrig merged commit d3be0f8 into nodejs:master Feb 13, 2017

@cjihrig cjihrig deleted the cjihrig:dgram-cluster-bind-error branch Feb 13, 2017

italoacasas added a commit to italoacasas/node that referenced this pull request Feb 14, 2017

test: cover cluster error during dgram socket bind
When a non-exclusive dgram socket is bound from a cluster
worker, a handle is requested from the cluster module. This
commit adds coverage for the case where an error occurs while
retrieving the handle.

PR-URL: nodejs#11295
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Mar 9, 2017

Member

Requires common.mustNotCall, needs a backport to land on either v6 or v4

Member

jasnell commented Mar 9, 2017

Requires common.mustNotCall, needs a backport to land on either v6 or v4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment