test: refactor test-repl-sigint-nested-eval #11303

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
6 participants
@Trott
Member

Trott commented Feb 10, 2017

  • remove debugging code that prints child stdout
  • indexOf() -> includes()
  • improved messages on assertion failures
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test repl

test: refactor test-repl-sigint-nested-eval
* remove debugging code that prints child stdout
* indexOf() -> includes()
* improved messages on assertion failures

@Trott Trott added repl test labels Feb 10, 2017

@Trott

This comment has been minimized.

Show comment
Hide comment
@lpinca

lpinca approved these changes Feb 12, 2017

Trott added a commit to Trott/io.js that referenced this pull request Feb 13, 2017

test: refactor test-repl-sigint-nested-eval
* remove debugging code that prints child stdout
* indexOf() -> includes()
* improved messages on assertion failures

PR-URL: nodejs#11303
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott

Trott Feb 13, 2017

Member

Landed in 4762791

Member

Trott commented Feb 13, 2017

Landed in 4762791

@Trott Trott closed this Feb 13, 2017

italoacasas added a commit to italoacasas/node that referenced this pull request Feb 14, 2017

test: refactor test-repl-sigint-nested-eval
* remove debugging code that prints child stdout
* indexOf() -> includes()
* improved messages on assertion failures

PR-URL: nodejs#11303
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>

jasnell added a commit that referenced this pull request Mar 7, 2017

test: refactor test-repl-sigint-nested-eval
* remove debugging code that prints child stdout
* indexOf() -> includes()
* improved messages on assertion failures

PR-URL: #11303
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>

MylesBorins added a commit that referenced this pull request Mar 9, 2017

test: refactor test-repl-sigint-nested-eval
* remove debugging code that prints child stdout
* indexOf() -> includes()
* improved messages on assertion failures

PR-URL: #11303
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>

@MylesBorins MylesBorins referenced this pull request Mar 9, 2017

Merged

v6.10.1 proposal #11759

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment