Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
errors, repl: migrate to use internal/errors.js #11347
@jasnell, pinging you for mentoring as this is my first PR to this project, thank you!
Affected core subsystem(s)
@fhinkel I rebased, squashed and implemented the change you proposed.
I'm not sure how to proceed now, can you please help me?
Fired up a CI to see how it goes anyway:
@no23reason can you help me with the error you're getting for this test?
* Use existing errors where suitable * Assign code to a REPL specific error * Include documentation for the new error code PR-URL: nodejs#11347 Ref: nodejs#11273 Reviewed-By: James M Snell <firstname.lastname@example.org> Reviewed-By: Tobias Nießen <email@example.com> Reviewed-By: Joyee Cheung <firstname.lastname@example.org> Reviewed-By: Michael Dawson <email@example.com>