New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

errors, repl: migrate to use internal/errors.js #11347

Closed
wants to merge 1 commit into
base: master
from

Conversation

@no23reason
Contributor

no23reason commented Feb 13, 2017

Migrated repl and internal/repl to internal/errors. Uses some code from #11294 as recommended in #11273.

@jasnell, pinging you for mentoring as this is my first PR to this project, thank you!

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

errors, REPL

@no23reason no23reason changed the title from Repl errors to errors, repl: migrate to use internal/errors.js Feb 13, 2017

@jasnell jasnell referenced this pull request Feb 14, 2017

Closed

Tracking Issue: Migrate errors to internal/errors.js #11273

78 of 80 tasks complete
Show outdated Hide outdated doc/api/errors.md Outdated
Show outdated Hide outdated doc/api/errors.md Outdated

@jasnell jasnell added the blocked label Apr 5, 2017

Show outdated Hide outdated doc/api/errors.md Outdated
@fhinkel

This comment has been minimized.

Show comment
Hide comment
@fhinkel

fhinkel May 23, 2017

Member

@no23reason Thanks so much for putting this together. Sorry that it is dragging out for so long due to being a semver-major change. Could you rebase and also squash your commits (I think all the changes should be one commit, right?). Thanks!

Member

fhinkel commented May 23, 2017

@no23reason Thanks so much for putting this together. Sorry that it is dragging out for so long due to being a semver-major change. Could you rebase and also squash your commits (I think all the changes should be one commit, right?). Thanks!

@no23reason

This comment has been minimized.

Show comment
Hide comment
@no23reason

no23reason May 23, 2017

Contributor
Contributor

no23reason commented May 23, 2017

@no23reason

This comment has been minimized.

Show comment
Hide comment
@no23reason

no23reason May 24, 2017

Contributor

@fhinkel I rebased, squashed and implemented the change you proposed.
However the tests are now failing on files I believe have nothing to do with my changes:

test\parallel\test-cluster-inspector-debug-port.js
test\sequential\test-net-connect-local-error.js
test\sequential\test-net-server-address.js

I'm not sure how to proceed now, can you please help me?

Contributor

no23reason commented May 24, 2017

@fhinkel I rebased, squashed and implemented the change you proposed.
However the tests are now failing on files I believe have nothing to do with my changes:

test\parallel\test-cluster-inspector-debug-port.js
test\sequential\test-net-connect-local-error.js
test\sequential\test-net-server-address.js

I'm not sure how to proceed now, can you please help me?

@joyeecheung

This comment has been minimized.

Show comment
Hide comment
@joyeecheung

joyeecheung May 25, 2017

Member

@no23reason
test-cluster-inspector-debug-port.js is in #12376 so that's probably the reason of failure. The rest I am not quite sure especially the flakiness of test-net-connect-local-error should have been addressed..

Fired up a CI to see how it goes anyway:
https://ci.nodejs.org/job/node-test-pull-request/8295/

Member

joyeecheung commented May 25, 2017

@no23reason
test-cluster-inspector-debug-port.js is in #12376 so that's probably the reason of failure. The rest I am not quite sure especially the flakiness of test-net-connect-local-error should have been addressed..

Fired up a CI to see how it goes anyway:
https://ci.nodejs.org/job/node-test-pull-request/8295/

@refack

This comment has been minimized.

Show comment
Hide comment
@refack

refack May 25, 2017

Member

test\sequential\test-net-connect-local-error.js

@no23reason can you help me with the error you're getting for this test?

  1. Paste the error output of the test (you can just run Release\node.exe test\sequential\test-net-connect-local-error.js, if it doesn't reproduce run python tools\test.py -v sequential to run the whole suite since sometimes tests interact with each other)
  2. Make sure commit 3429c90 is in your tree

Ref: #13064

Member

refack commented May 25, 2017

test\sequential\test-net-connect-local-error.js

@no23reason can you help me with the error you're getting for this test?

  1. Paste the error output of the test (you can just run Release\node.exe test\sequential\test-net-connect-local-error.js, if it doesn't reproduce run python tools\test.py -v sequential to run the whole suite since sometimes tests interact with each other)
  2. Make sure commit 3429c90 is in your tree

Ref: #13064

@no23reason

This comment has been minimized.

Show comment
Hide comment
@no23reason

no23reason May 25, 2017

Contributor

OK, so today I tried the build again on a clean checkout of the repo and suddenly all the tests pass except the test\parallel\test-cluster-inspector-debug-port.js
So I guess everything is OK now, right? Sorry for the false alarm

Contributor

no23reason commented May 25, 2017

OK, so today I tried the build again on a clean checkout of the repo and suddenly all the tests pass except the test\parallel\test-cluster-inspector-debug-port.js
So I guess everything is OK now, right? Sorry for the false alarm

@refack

This comment has been minimized.

Show comment
Hide comment
@refack

refack May 25, 2017

Member

Sorry for the false alarm

NP. Dirty builds happen all the time 🤷‍♂️ ... Especially on Windows

Member

refack commented May 25, 2017

Sorry for the false alarm

NP. Dirty builds happen all the time 🤷‍♂️ ... Especially on Windows

Show outdated Hide outdated doc/api/errors.md Outdated
Show outdated Hide outdated doc/api/errors.md Outdated
Show outdated Hide outdated lib/internal/errors.js Outdated
@jasnell

LGTM with a nit

@joyeecheung

This comment has been minimized.

Show comment
Hide comment
Member

joyeecheung commented May 30, 2017

@mhdawson

LGTM

@joyeecheung joyeecheung removed the blocked label Jun 2, 2017

@joyeecheung

This comment has been minimized.

Show comment
Hide comment
@joyeecheung

joyeecheung Jun 2, 2017

Member

#13299 has already landed so unfortunately we can not get this PR in anymore . Thanks for the contribution anyway!

Member

joyeecheung commented Jun 2, 2017

#13299 has already landed so unfortunately we can not get this PR in anymore . Thanks for the contribution anyway!

@joyeecheung

This comment has been minimized.

Show comment
Hide comment
@joyeecheung

joyeecheung Jun 2, 2017

Member

Oh, looks like #13299 only contains part of what this PR does, so this still adds something that isn't in the codebase yet. @no23reason can do a rebase again? Thanks!

Member

joyeecheung commented Jun 2, 2017

Oh, looks like #13299 only contains part of what this PR does, so this still adds something that isn't in the codebase yet. @no23reason can do a rebase again? Thanks!

@no23reason

This comment has been minimized.

Show comment
Hide comment
@no23reason

no23reason Jun 2, 2017

Contributor

@joyeecheung I rebased and removed the error code that is now obsolete.

Contributor

no23reason commented Jun 2, 2017

@joyeecheung I rebased and removed the error code that is now obsolete.

Show outdated Hide outdated doc/api/errors.md Outdated
Show outdated Hide outdated lib/internal/errors.js Outdated
errors, repl: migrate to use internal/errors.js
* Use existing errors where suitable
* Assign code to a REPL specific error
* Include documentation for the new error code

@tniessen tniessen self-assigned this Jun 14, 2017

@tniessen

This comment has been minimized.

Show comment
Hide comment
@tniessen
Member

tniessen commented Jun 14, 2017

@tniessen tniessen closed this Jun 14, 2017

@tniessen tniessen reopened this Jun 14, 2017

@refack

This comment has been minimized.

Show comment
Hide comment
@refack

refack Jun 14, 2017

Member

For my bookkeeping: #13686

Member

refack commented Jun 14, 2017

For my bookkeeping: #13686

tniessen added a commit to tniessen/node that referenced this pull request Jun 14, 2017

errors, repl: migrate to use internal/errors.js
* Use existing errors where suitable
* Assign code to a REPL specific error
* Include documentation for the new error code

PR-URL: nodejs#11347
Ref: nodejs#11273
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@tniessen

This comment has been minimized.

Show comment
Hide comment
@tniessen

tniessen Jun 14, 2017

Member

Landed in aff8d35, thank you for your first contribution! 🎉 We'd be happy to see more!

(And sorry for closing this prematurely, mixed this up with another PR.)

Member

tniessen commented Jun 14, 2017

Landed in aff8d35, thank you for your first contribution! 🎉 We'd be happy to see more!

(And sorry for closing this prematurely, mixed this up with another PR.)

@tniessen tniessen closed this Jun 14, 2017

@no23reason

This comment has been minimized.

Show comment
Hide comment
@no23reason

no23reason Jun 15, 2017

Contributor

@tniessen Thank you for your patience and advice, I hope my next contributions will be smoother :)

Contributor

no23reason commented Jun 15, 2017

@tniessen Thank you for your patience and advice, I hope my next contributions will be smoother :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment