Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test, url: turn on WPT tests on empty params pairs #11369

Closed
wants to merge 1 commit into from

Conversation

@joyeecheung
Copy link
Member

commented Feb 14, 2017

This is fixed by #11234. This PR turns on the tests accordingly.

Refs: #11234

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

url-whatwg, test

@TimothyGu

This comment has been minimized.

@TimothyGu
Copy link
Member

left a comment

CI is green (except for ARM but the error looks unrelated). LGTM.

@TimothyGu TimothyGu added this to doc / benchmark / test in WHATWG URL implementation Feb 14, 2017

@TimothyGu

This comment has been minimized.

Copy link
Member

commented Feb 17, 2017

Landed in 82ddf96.

@TimothyGu TimothyGu closed this Feb 17, 2017

@TimothyGu TimothyGu moved this from doc / benchmark / test to Done in WHATWG URL implementation Feb 17, 2017

TimothyGu added a commit that referenced this pull request Feb 17, 2017
test: turn on WPT tests on empty param pairs
This specific bug was fixed by #11234. This commit turns on the tests
accordingly.

PR-URL: #11369
Ref: #11234
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@jasnell jasnell referenced this pull request Apr 4, 2017
@gibfahn gibfahn referenced this pull request Jun 15, 2017
2 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
7 participants
You can’t perform that action at this time.