New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

errors, readline: migrate to use internal/errors.js #11390

Closed
wants to merge 7 commits into
base: master
from

Conversation

Projects
6 participants
@slammayjammay
Contributor

slammayjammay commented Feb 15, 2017

Migrate lib/readline.js to use internal/errors.js.

Refs: #11273

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

errors, readline

Show outdated Hide outdated lib/readline.js
Show outdated Hide outdated lib/readline.js

@joyeecheung joyeecheung referenced this pull request Feb 15, 2017

Closed

timers, errors: migrate to internal/errors.js #11384

3 of 3 tasks complete

@jasnell jasnell referenced this pull request Feb 15, 2017

Closed

Tracking Issue: Migrate errors to internal/errors.js #11273

78 of 80 tasks complete

@jasnell jasnell added the blocked label Apr 5, 2017

@fhinkel

This comment has been minimized.

Show comment
Hide comment
@fhinkel

fhinkel May 23, 2017

Member

@slammayjammay Thanks so much for putting this together. Sorry that it is dragging out for so long due to being a semver-major change. Do you want to address the comments and rebase? Thanks!

Member

fhinkel commented May 23, 2017

@slammayjammay Thanks so much for putting this together. Sorry that it is dragging out for so long due to being a semver-major change. Do you want to address the comments and rebase? Thanks!

@slammayjammay

This comment has been minimized.

Show comment
Hide comment
@slammayjammay

slammayjammay May 24, 2017

Contributor

@fhinkel Whoops, forgot about this! Sure, I'll find some time this week to address the feedback.

Contributor

slammayjammay commented May 24, 2017

@fhinkel Whoops, forgot about this! Sure, I'll find some time this week to address the feedback.

@joyeecheung

This comment has been minimized.

Show comment
Hide comment
Show outdated Hide outdated doc/api/errors.md

@joyeecheung joyeecheung removed the blocked label May 27, 2017

Show outdated Hide outdated lib/internal/errors.js
@joyeecheung

This comment has been minimized.

Show comment
Hide comment
@mhdawson

LGTM

@mhdawson

This comment has been minimized.

Show comment
Hide comment
@mhdawson

mhdawson Jun 6, 2017

Member

@slammayjammay looks good, but unfortunately needs a rebase.

Member

mhdawson commented Jun 6, 2017

@slammayjammay looks good, but unfortunately needs a rebase.

@joyeecheung

This comment has been minimized.

Show comment
Hide comment

jasnell added a commit that referenced this pull request Jun 13, 2017

errors, readline: migrate to use internal/errors.js
PR-URL: #11390
Ref: #11273
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Jun 13, 2017

Member

Landed in 7f3f72c

Member

jasnell commented Jun 13, 2017

Landed in 7f3f72c

@jasnell jasnell closed this Jun 13, 2017

@refack refack added this to Done in Error Codes Aug 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment