New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug: activate inspector with _debugProcess #11431

Merged
merged 0 commits into from Apr 6, 2017

Conversation

Projects
None yet
9 participants
@eugeneo
Contributor

eugeneo commented Feb 16, 2017

This pull request switches the signal handler to start inspector socket
server instead of the legacy V8 debug protocol.

Fixes: #8464

CC: @ofrobots

@eugeneo

This comment has been minimized.

Show comment
Hide comment
@eugeneo
Contributor

eugeneo commented Feb 16, 2017

@eugeneo

This comment has been minimized.

Show comment
Hide comment
@eugeneo

eugeneo Feb 17, 2017

Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/6457/

ARM failures are parallel/test-dgram-address that does not seem to be influenced by this change.

Contributor

eugeneo commented Feb 17, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/6457/

ARM failures are parallel/test-dgram-address that does not seem to be influenced by this change.

@ofrobots

This comment has been minimized.

Show comment
Hide comment
@ofrobots
Contributor

ofrobots commented Feb 17, 2017

@addaleax

Left a few comments … the size of the diff makes it quite difficult to tell code that was just moved around from actual changes, by the way. I don’t know if splitting into several commits would have been a possibility here, but that would make reviewing a lot easier…

Show outdated Hide outdated src/inspector_agent.cc
Show outdated Hide outdated src/inspector_agent.cc
Show outdated Hide outdated src/inspector_agent.h
Show outdated Hide outdated src/inspector_agent.h
Show outdated Hide outdated src/inspector_io.cc
@eugeneo

This comment has been minimized.

Show comment
Hide comment
@eugeneo

eugeneo Feb 21, 2017

Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/6527/

I do not see ARM failures through the Hudson - I think GitHub integration might be glitchy.

Contributor

eugeneo commented Feb 21, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/6527/

I do not see ARM failures through the Hudson - I think GitHub integration might be glitchy.

@jkrems

This comment has been minimized.

Show comment
Hide comment
@jkrems

jkrems Mar 16, 2017

Contributor

Tried this change against node-inspect and it worked as expected.

Contributor

jkrems commented Mar 16, 2017

Tried this change against node-inspect and it worked as expected.

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Mar 22, 2017

Member

What's the status on this?

Member

jasnell commented Mar 22, 2017

What's the status on this?

@eugeneo

This comment has been minimized.

Show comment
Hide comment
@eugeneo

eugeneo Mar 22, 2017

Contributor

@jasnell I am not sure. Code-wise it is ready for the review. A decision needs to be made when the old debugger stops handling the signal - is this something that needs to be discussed by @nodejs/diagnostics?

Contributor

eugeneo commented Mar 22, 2017

@jasnell I am not sure. Code-wise it is ready for the review. A decision needs to be made when the old debugger stops handling the signal - is this something that needs to be discussed by @nodejs/diagnostics?

@jkrems

This comment has been minimized.

Show comment
Hide comment
@jkrems

jkrems Mar 22, 2017

Contributor

@joshgav Can we pull this into tomorrow's meeting? I think it boils down to a unified "master plan" for doing the switch and when to land what and where.

Contributor

jkrems commented Mar 22, 2017

@joshgav Can we pull this into tomorrow's meeting? I think it boils down to a unified "master plan" for doing the switch and when to land what and where.

@joshgav joshgav added the diag-agenda label Mar 22, 2017

@joshgav

This comment has been minimized.

Show comment
Hide comment
@joshgav

joshgav Mar 22, 2017

Member

@jkrems sure, just added label.

Member

joshgav commented Mar 22, 2017

@jkrems sure, just added label.

@eugeneo

This comment has been minimized.

Show comment
Hide comment
@eugeneo

eugeneo Mar 22, 2017

Contributor

@jkrems, @joshgav - how can I join the meeting? I tried looking through the https://github.com/nodejs/diagnostics but did not find details about the upcoming meeting.

Contributor

eugeneo commented Mar 22, 2017

@jkrems, @joshgav - how can I join the meeting? I tried looking through the https://github.com/nodejs/diagnostics but did not find details about the upcoming meeting.

@jkrems

This comment has been minimized.

Show comment
Hide comment
@jkrems

jkrems Mar 22, 2017

Contributor

@eugeneo This is the meta issue for the meeting: nodejs/diagnostics#89

Contributor

jkrems commented Mar 22, 2017

@eugeneo This is the meta issue for the meeting: nodejs/diagnostics#89

@bnoordhuis

Mea culpa, looks like I reviewed this back in February but forgot to submit the comments. Re-reviewed; needs a rebase but the conflicts look minor.

Show outdated Hide outdated src/inspector_agent.cc
Show outdated Hide outdated src/inspector_agent.cc
Show outdated Hide outdated src/inspector_agent.cc
Show outdated Hide outdated src/inspector_agent.cc
Show outdated Hide outdated src/inspector_agent.cc
Show outdated Hide outdated src/inspector_agent.cc
Show outdated Hide outdated src/inspector_io.cc
Show outdated Hide outdated src/inspector_io.cc
Show outdated Hide outdated src/inspector_io.cc
Show outdated Hide outdated src/node_debug_options.cc
@eugeneo

This comment has been minimized.

Show comment
Hide comment
@eugeneo

eugeneo Mar 29, 2017

Contributor

Thank you for the review. Please take another look.

Contributor

eugeneo commented Mar 29, 2017

Thank you for the review. Please take another look.

@eugeneo

This comment has been minimized.

Show comment
Hide comment
@eugeneo

eugeneo Mar 31, 2017

Contributor

I did a rebase to account for the latest changes. Please review.

Contributor

eugeneo commented Mar 31, 2017

I did a rebase to account for the latest changes. Please review.

@jkrems

This comment has been minimized.

Show comment
Hide comment
@jkrems

jkrems Apr 3, 2017

Contributor

Looks like there's one stray lint error:

src/inspector_io.h:119:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
Contributor

jkrems commented Apr 3, 2017

Looks like there's one stray lint error:

src/inspector_io.h:119:  Lines should be <= 80 characters long  [whitespace/line_length] [2]

@jkrems jkrems referenced this pull request Apr 3, 2017

Closed

src: Remove support for --debug #12197

4 of 4 tasks complete
@eugeneo

This comment has been minimized.

Show comment
Hide comment
@eugeneo

eugeneo Apr 3, 2017

Contributor

@jkrems thanks for pointing that out, I fixed it.

Contributor

eugeneo commented Apr 3, 2017

@jkrems thanks for pointing that out, I fixed it.

@eugeneo

This comment has been minimized.

Show comment
Hide comment
Contributor

eugeneo commented Apr 3, 2017

@bnoordhuis

LGTM sans some final comments. Have you checked if ./configure --without-inspector still builds?

Show outdated Hide outdated src/inspector_agent.cc
Show outdated Hide outdated src/inspector_agent.cc
Show outdated Hide outdated src/inspector_agent.cc
Show outdated Hide outdated src/inspector_agent.cc
Show outdated Hide outdated src/inspector_agent.cc
Show outdated Hide outdated src/inspector_io.cc
Show outdated Hide outdated src/inspector_io.cc
Show outdated Hide outdated src/inspector_io.cc
Show outdated Hide outdated src/inspector_io.cc
Show outdated Hide outdated src/node.cc

@jkrems jkrems referenced this pull request Apr 4, 2017

Closed

[WIP] deps: Update node-inspect to v1.11.0 #12214

3 of 3 tasks complete
@eugeneo

This comment has been minimized.

Show comment
Hide comment
@eugeneo

eugeneo Apr 4, 2017

Contributor

@bnoordhuis I moved the _debugProcess code back to node.cc so the node built with --without-inspector would still be able to send signal/do the weird Windows stuff to another Node instance. What do you think?

Contributor

eugeneo commented Apr 4, 2017

@bnoordhuis I moved the _debugProcess code back to node.cc so the node built with --without-inspector would still be able to send signal/do the weird Windows stuff to another Node instance. What do you think?

@bnoordhuis

This comment has been minimized.

Show comment
Hide comment
@bnoordhuis

bnoordhuis Apr 4, 2017

Member

@eugeneo Did you forget to push? I still see RegisterDebugSignalHandler() and friends in inspector_agent.cc, not node.cc.

(Happy to hear I'm not the only one who thinks the Windows code is weird. I'm not even sure why it works.)

Member

bnoordhuis commented Apr 4, 2017

@eugeneo Did you forget to push? I still see RegisterDebugSignalHandler() and friends in inspector_agent.cc, not node.cc.

(Happy to hear I'm not the only one who thinks the Windows code is weird. I'm not even sure why it works.)

@eugeneo

This comment has been minimized.

Show comment
Hide comment
@eugeneo

eugeneo Apr 4, 2017

Contributor

Signal handler remains there, it is only the code that sends the signal that was moved back. (I see CI failures, looking into them)

Contributor

eugeneo commented Apr 4, 2017

Signal handler remains there, it is only the code that sends the signal that was moved back. (I see CI failures, looking into them)

@eugeneo

This comment has been minimized.

Show comment
Hide comment
@eugeneo
Contributor

eugeneo commented Apr 5, 2017

@eugeneo

This comment has been minimized.

Show comment
Hide comment
@eugeneo

eugeneo Apr 5, 2017

Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/7219/ - OS X is passing, even though its status is not properly reported.

Contributor

eugeneo commented Apr 5, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/7219/ - OS X is passing, even though its status is not properly reported.

@ofrobots ofrobots referenced this pull request Apr 5, 2017

Closed

doc: deprecate vm.runInDebugContext #12243

4 of 4 tasks complete

@eugeneo eugeneo closed this Apr 6, 2017

@eugeneo eugeneo deleted the eugeneo:inspector-signal branch Apr 6, 2017

@eugeneo eugeneo merged commit 7599b0e into nodejs:master Apr 6, 2017

@eugeneo

This comment has been minimized.

Show comment
Hide comment
@eugeneo

eugeneo Apr 6, 2017

Contributor

Landed as 7599b0e

Contributor

eugeneo commented Apr 6, 2017

Landed as 7599b0e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment