test: skip IPv6 test on non-IPv6 systems #11432

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
5 participants
@Trott
Member

Trott commented Feb 16, 2017

Until recently, test-dgram-address would fail on machines without IPv6 but still exit
with a successful return code. (It would console.log() the error but not
actually fail.)

Now that the test has been updated such that it will fail the IPv6 part
of the test if there is an error event emitted by the socket, skip the
test on systems not equipped with IPv6.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test dgram

test: skip IPv6 test on non-IPv6 systems
Until recently, test-dgram-address would fail on IPv6 but still exit
with a successful return code. (It would console.log() the error but not
actually fail.)

Now that the test has been updated such that it will fail the IPv6 part
of the test if there is an error event emitted by the socket, skip the
test on systems not equipped with IPv6.

@Trott Trott added dgram test labels Feb 16, 2017

@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott

Trott Feb 16, 2017

Member

This fixes an issue that is currently causing CI to fail every time for two of the three Raspberry Pi setups we have in CI. I propose not waiting the 48 hours on this one and landing much sooner. /cc @nodejs/testing @cjihrig

Member

Trott commented Feb 16, 2017

This fixes an issue that is currently causing CI to fail every time for two of the three Raspberry Pi setups we have in CI. I propose not waiting the 48 hours on this one and landing much sooner. /cc @nodejs/testing @cjihrig

@Trott

This comment has been minimized.

Show comment
Hide comment
@rvagg

This comment has been minimized.

Show comment
Hide comment
@rvagg

rvagg Feb 16, 2017

Member

I'm gathering this is because of #11271

Also of note that this is only failing on Wheezy systems and not Jessie, so it's something about kernel or libc versions I suppose.

LGTM though! Also +1 on expedited landing. Thanks for jumping on this @Trott

Member

rvagg commented Feb 16, 2017

I'm gathering this is because of #11271

Also of note that this is only failing on Wheezy systems and not Jessie, so it's something about kernel or libc versions I suppose.

LGTM though! Also +1 on expedited landing. Thanks for jumping on this @Trott

@rvagg rvagg referenced this pull request in nodejs/build Feb 16, 2017

Closed

ARM cluster move #611

@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott

Trott Feb 16, 2017

Member

CI again (build failure on one host): https://ci.nodejs.org/job/node-test-pull-request/6456/

Member

Trott commented Feb 16, 2017

CI again (build failure on one host): https://ci.nodejs.org/job/node-test-pull-request/6456/

Trott added a commit to Trott/io.js that referenced this pull request Feb 17, 2017

test: skip IPv6 test on non-IPv6 systems
Until recently, test-dgram-address would fail on machines without IPv6
but still exit with a successful return code. (It would console.log()
the error but not actually fail.)

Now that the test has been updated such that it will fail the IPv6 part
of the test if there is an error event emitted by the socket, skip the
test on systems not equipped with IPv6.

PR-URL: nodejs#11432
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott

Trott Feb 17, 2017

Member

Landed in d9a14b7

Member

Trott commented Feb 17, 2017

Landed in d9a14b7

@Trott Trott closed this Feb 17, 2017

italoacasas added a commit to italoacasas/node that referenced this pull request Feb 20, 2017

test: skip IPv6 test on non-IPv6 systems
Until recently, test-dgram-address would fail on machines without IPv6
but still exit with a successful return code. (It would console.log()
the error but not actually fail.)

Now that the test has been updated such that it will fail the IPv6 part
of the test if there is an error event emitted by the socket, skip the
test on systems not equipped with IPv6.

PR-URL: nodejs#11432
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rod Vagg <rod@vagg.org>

italoacasas added a commit that referenced this pull request Feb 21, 2017

test: skip IPv6 test on non-IPv6 systems
Until recently, test-dgram-address would fail on machines without IPv6
but still exit with a successful return code. (It would console.log()
the error but not actually fail.)

Now that the test has been updated such that it will fail the IPv6 part
of the test if there is an error event emitted by the socket, skip the
test on systems not equipped with IPv6.

PR-URL: #11432
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Mar 9, 2017

Member

needs backport PRs in order to land on v6 or v4

Member

jasnell commented Mar 9, 2017

needs backport PRs in order to land on v6 or v4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment