New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

console: fixup `console.dir()` error handling #11443

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@addaleax
Member

addaleax commented Feb 17, 2017

Apply the console: do not emit error events changes properly to console.dir().

This was overlooked in f18e08d (#9744).

Ref: f18e08d#commitcomment-20934407

/cc @Fishrock123

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

console

console: fixup `console.dir()` error handling
Apply the `console: do not emit error events` changes properly
to `console.dir()`.

This was overlooked in f18e08d
(#9744).

Ref: f18e08d#commitcomment-20934407
@addaleax

This comment has been minimized.

Show comment
Hide comment
@addaleax

This comment has been minimized.

Show comment
Hide comment
@addaleax

addaleax Feb 21, 2017

Member

Landed in c969047

Member

addaleax commented Feb 21, 2017

Landed in c969047

@addaleax addaleax closed this Feb 21, 2017

@addaleax addaleax deleted the addaleax:console-no-errors2-fixup branch Feb 21, 2017

addaleax added a commit that referenced this pull request Feb 21, 2017

console: fixup `console.dir()` error handling
Apply the `console: do not emit error events` changes properly
to `console.dir()`.

This was overlooked in f18e08d
(#9744).

Ref: f18e08d#commitcomment-20934407
PR-URL: #11443
Reviewed-By: James M Snell <jasnell@gmail.com>

@jasnell jasnell referenced this pull request Apr 4, 2017

Closed

8.0.0 Release Proposal #12220

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment