Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
tls: use emitWarning() for dhparam < 2048 bits #11447
When a dhparam less than 2048 bits was used, a warning was being printed directly to console.error using an internalUtil.trace function that was not used anywhere else. This replaces it with a proper process warning and removes the internalUtil.trace function.
Affected core subsystem(s)
This one is likely obscure enough that it wouldn't matter but there no harm in being careful. I'm good with semver-major…
On Mon, Feb 20, 2017 at 12:16 AM Rod Vagg ***@***.***> wrote: LGTM, but are we doing semver-major for these? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#11447 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAa2ec-sMpJZoo_1OlFBm8FQmfPFp1gfks5reUvBgaJpZM4ME2xk> .
If I read the diff correctly, the message on stderr changed from
So its got to be semver-major.
It could probably be backported with a warning name of