Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add two test cases for querystring #11481

Closed
wants to merge 1 commit into from

Conversation

@watilde
Copy link
Member

commented Feb 21, 2017

This test will improve querystring coverage:

The following lines will be called with the cases:

Checklist
  • make -j4 test
  • tests are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@mscdex

This comment has been minimized.

Copy link
Contributor

commented Feb 21, 2017

I think just using 'test' for the subsystem in the first line of the commit is enough, as no change to the actual querystring module is being made in this PR.

CI: https://ci.nodejs.org/job/node-test-pull-request/6530/

@watilde

This comment has been minimized.

Copy link
Member Author

commented Feb 21, 2017

Ahh ok, now the tagging rule becomes apparent to me. Thanks!
I will update the message, and also probably I should squash the commits into one commit.

test: add two test cases for querystring
+ Check an empty substring: In `querystring`, if the `maxKeys` is 1
  and the state machine finds an empty substring between separators,
  it should return an empty object.
+ Test invalid encoded strings: If provided string is an invalid
  encoded string in `query.parse`, it will not be encoded.

@watilde watilde force-pushed the watilde:test-querystring branch to 6913df6 Feb 21, 2017

@mscdex mscdex changed the title test,querystring: improve querystring coverage to cover two more lines test: add two test cases for querystring Feb 21, 2017

jasnell added a commit that referenced this pull request Feb 24, 2017
test: add two test cases for querystring
+ Check an empty substring: In `querystring`, if the `maxKeys` is 1
  and the state machine finds an empty substring between separators,
  it should return an empty object.
+ Test invalid encoded strings: If provided string is an invalid
  encoded string in `query.parse`, it will not be encoded.

PR-URL: #11481
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell

This comment has been minimized.

Copy link
Member

commented Feb 24, 2017

@addaleax ... just fyi, I was landing this PR just as your review came in so you're not listed on the reviewers

@jasnell

This comment has been minimized.

Copy link
Member

commented Feb 24, 2017

Landed in dd2e135

@jasnell jasnell closed this Feb 24, 2017

@addaleax

This comment has been minimized.

Copy link
Member

commented Feb 24, 2017

@jasnell guess what I was just going to push to master! 😄

@watilde watilde deleted the watilde:test-querystring branch Feb 24, 2017

@italoacasas

This comment has been minimized.

Copy link
Member

commented Feb 25, 2017

not landing in v7.x-staging at the moment because one test is failing. Any plan to backport?

@jasnell jasnell referenced this pull request Apr 4, 2017
@gibfahn gibfahn referenced this pull request Jun 15, 2017
2 of 3 tasks complete
@gibfahn

This comment has been minimized.

Copy link
Member

commented Jun 17, 2017

Should this be backported to v6.x-staging? If yes please follow the guide and raise a backport PR, if no let me know or add the dont-land-on label.

@watilde

This comment has been minimized.

Copy link
Member Author

commented Jun 18, 2017

Since this update was related to the breaking change of the querystring in v8.x, I replaced backport label with dont-land-on. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
9 participants
You can’t perform that action at this time.