New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error,test: migrating error to internal/errors #11505

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
7 participants
@larissayvette
Contributor

larissayvette commented Feb 22, 2017

Checklist
Affected core subsystem(s)

error,lib

Assign error code to TypeError in assert.js

@mscdex

This comment has been minimized.

Show comment
Hide comment
@mscdex

mscdex Feb 22, 2017

Contributor

Minor nit: there's a typo in the commit message: s/intenal/internal/

Contributor

mscdex commented Feb 22, 2017

Minor nit: there's a typo in the commit message: s/intenal/internal/

@Trott

This comment has been minimized.

Show comment
Hide comment
Show outdated Hide outdated lib/internal/errors.js
Show outdated Hide outdated test/parallel/test-assert.js

@larissayvette larissayvette changed the title from error,test: migrating error to intenal/errors to error,test: migrating error to internal/errors Feb 24, 2017

@jasnell jasnell added the blocked label Apr 5, 2017

@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott

Trott May 6, 2017

Member

Rebased, resolved conflicts, nits addressed, removing blocked label (/cc @jasnell), will run CI.

Are these things semver-major?

PTAL!

CI: https://ci.nodejs.org/job/node-test-pull-request/7909/

Member

Trott commented May 6, 2017

Rebased, resolved conflicts, nits addressed, removing blocked label (/cc @jasnell), will run CI.

Are these things semver-major?

PTAL!

CI: https://ci.nodejs.org/job/node-test-pull-request/7909/

@Trott Trott removed the blocked label May 6, 2017

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell May 6, 2017

Member

Yes, they are semver-major for the initially switch over to internal/errors due to the likelihood of changing error messages and the fact that none of this has been ported back to any release branch.

Member

jasnell commented May 6, 2017

Yes, they are semver-major for the initially switch over to internal/errors due to the likelihood of changing error messages and the fact that none of this has been ported back to any release branch.

@jasnell

jasnell approved these changes May 6, 2017

@Trott Trott added the semver-major label May 6, 2017

assert.ok(threw);
testBlockTypeError(assert.throws, 'string');

This comment has been minimized.

@addaleax

addaleax May 6, 2017

Member

Just a suggestion, but I think it would be nice if these could be turned into
testBlockTypeError(() => assert.throws('string')); etc.

@addaleax

addaleax May 6, 2017

Member

Just a suggestion, but I think it would be nice if these could be turned into
testBlockTypeError(() => assert.throws('string')); etc.

This comment has been minimized.

@Trott

Trott May 6, 2017

Member

@addaleax Tempted to leave this PR as-is just so I can put your suggestion on a list for Code + Learn... Is that unhealthy? :-P

@Trott

Trott May 6, 2017

Member

@addaleax Tempted to leave this PR as-is just so I can put your suggestion on a list for Code + Learn... Is that unhealthy? :-P

This comment has been minimized.

@addaleax

addaleax May 6, 2017

Member

That’s perfectly okay :)

@addaleax

addaleax May 6, 2017

Member

That’s perfectly okay :)

This comment has been minimized.

@Trott

Trott Jul 7, 2017

Member

@addaleax Having a hard time writing this up for Code + Learn in a way that makes it clear why we want to do this. (Probably because I see it as a style preference.) Would you want to try? If not, no biggie, I'll just leave it off the list. We have enough tasks for the next Code + Learn.

@Trott

Trott Jul 7, 2017

Member

@addaleax Having a hard time writing this up for Code + Learn in a way that makes it clear why we want to do this. (Probably because I see it as a style preference.) Would you want to try? If not, no biggie, I'll just leave it off the list. We have enough tasks for the next Code + Learn.

Trott added a commit to Trott/io.js that referenced this pull request May 6, 2017

errors,test: migrating error to internal/errors
PR-URL: nodejs#11505
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott

Trott May 6, 2017

Member

Landed in 1c834e7

Member

Trott commented May 6, 2017

Landed in 1c834e7

@Trott Trott closed this May 6, 2017

anchnk added a commit to anchnk/node that referenced this pull request May 19, 2017

errors,test: migrating error to internal/errors
PR-URL: nodejs#11505
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

@jasnell jasnell referenced this pull request May 11, 2017

Closed

8.0.0 Release Proposal #12220

@refack refack added this to Done in Error Codes Aug 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment