New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: build a x64 build by default on Windows #11537

Merged
merged 1 commit into from Feb 28, 2017

Conversation

Projects
None yet
5 participants
@seishun
Member

seishun commented Feb 24, 2017

Checklist
  • commit message follows commit guidelines
Affected core subsystem(s)

build

I'm quite sure most people are interested in x64 builds in 2017, and defaulting to x86 causes confusion, see for example #11500.

@gibfahn

LGTM (and this seems like a sensible suggestion).

@@ -14,7 +14,7 @@ if /i "%1"=="/?" goto help
@rem Process arguments.
set config=Release
set target=Build
set target_arch=x86
set target_arch=x64

This comment has been minimized.

@gibfahn

gibfahn Feb 24, 2017

Member

Would this be a semver-major change? I'm not really sure how we treat breaking tooling changes.

@gibfahn

gibfahn Feb 24, 2017

Member

Would this be a semver-major change? I'm not really sure how we treat breaking tooling changes.

This comment has been minimized.

@seishun

seishun Feb 24, 2017

Member

#10156 was semver-major, so I guess this one is too. I'd be fine with that though since vcbuild is mostly used to build master anyway.

@seishun

seishun Feb 24, 2017

Member

#10156 was semver-major, so I guess this one is too. I'd be fine with that though since vcbuild is mostly used to build master anyway.

This comment has been minimized.

@richardlau

richardlau Feb 24, 2017

Member

Is it possible to detect if the OS is 64-bit like the Makefile does on the Unix platforms?

@richardlau

richardlau Feb 24, 2017

Member

Is it possible to detect if the OS is 64-bit like the Makefile does on the Unix platforms?

This comment has been minimized.

@richardlau

richardlau Feb 24, 2017

Member

The configure script checks some environment variables on Windows: https://github.com/nodejs/node/blob/master/configure#L735-L748

@richardlau

richardlau Feb 24, 2017

Member

The configure script checks some environment variables on Windows: https://github.com/nodejs/node/blob/master/configure#L735-L748

This comment has been minimized.

@gibfahn

gibfahn Feb 25, 2017

Member

I'm not sure it's necessary to detect whether the OS is 64-bit, defaulting to 64-bit seems reasonable and straightforward.

Detecting the ARCH from environment variables seems flaky, and what you really want is to be sure that you're going to get 64/32 bit reliably. I think anyone building 32-bit is probably aware that they'll have to set something.

cc/ @nodejs/platform-windows

@gibfahn

gibfahn Feb 25, 2017

Member

I'm not sure it's necessary to detect whether the OS is 64-bit, defaulting to 64-bit seems reasonable and straightforward.

Detecting the ARCH from environment variables seems flaky, and what you really want is to be sure that you're going to get 64/32 bit reliably. I think anyone building 32-bit is probably aware that they'll have to set something.

cc/ @nodejs/platform-windows

This comment has been minimized.

@seishun

seishun Feb 25, 2017

Member

I agree, it's better to have the same behavior independent of the platform.

@seishun

seishun Feb 25, 2017

Member

I agree, it's better to have the same behavior independent of the platform.

This comment has been minimized.

@richardlau

richardlau Feb 25, 2017

Member

Will it be obvious why the build fails if run on 32-bit Windows? ¯_(ツ)_/¯

In any case #11500 points out that specifying the architecture is currently undocumented regardless of whatever the default is.

@richardlau

richardlau Feb 25, 2017

Member

Will it be obvious why the build fails if run on 32-bit Windows? ¯_(ツ)_/¯

In any case #11500 points out that specifying the architecture is currently undocumented regardless of whatever the default is.

@seishun seishun merged commit d088360 into nodejs:master Feb 28, 2017

@jasnell jasnell referenced this pull request Apr 4, 2017

Closed

8.0.0 Release Proposal #12220

@seishun seishun deleted the seishun:x64-default branch Oct 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment