Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add two test cases for querystring #11551

Closed
wants to merge 1 commit into from

Conversation

@watilde
Copy link
Member

commented Feb 25, 2017

Test cases:

  • Cover untested branch in the state machine with the strings that its first letter is + in the key/value.
  • qs.unescapeBuffer shouldn't decode + to space.

This test increases the coverage of querystring.js:

The following branches will be skipped:

Checklist
  • make -j4 test
  • tests are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

test: add two test cases for querystring
+ Cover untested branch in the state machine with the string
  that its first letter is `+` in the key/value.
+ `qs.unescapeBuffer` shouldn't decode `+` to space.
@jasnell

This comment has been minimized.

@addaleax

This comment has been minimized.

Copy link
Member

commented Mar 1, 2017

Landed in acc3a80

@addaleax addaleax closed this Mar 1, 2017

addaleax added a commit that referenced this pull request Mar 1, 2017
test: add two test cases for querystring
+ Cover untested branch in the state machine with the string
  that its first letter is `+` in the key/value.
+ `qs.unescapeBuffer` shouldn't decode `+` to space.

PR-URL: #11551
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

@watilde watilde deleted the watilde:test/querystring branch Mar 1, 2017

@evanlucas

This comment has been minimized.

Copy link
Member

commented Mar 7, 2017

This is not landing cleanly on v7.x-staging. Mind submitting a backport PR?

@jasnell jasnell referenced this pull request Apr 4, 2017
@gibfahn gibfahn referenced this pull request Jun 15, 2017
2 of 3 tasks complete
@gibfahn

This comment has been minimized.

Copy link
Member

commented Jun 17, 2017

Should this be backported to v6.x-staging? If yes please follow the guide and raise a backport PR, if no let me know or add the dont-land-on label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
9 participants
You can’t perform that action at this time.