Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
http: should support userland Agent #11567
#10053 assert agent must be instance of
I think we should keep userland Agents still can work on the future is very important.
Affected core subsystem(s)
Why can't such models just inherit from
We don't explicitly say in the docs that you should subclass
http.Agent. We suggest it in one place but not very explicitly.
On the other hand, if you don't subclass, you must have reverse-engineered its implementation from node's sources, so you probably knew what you were getting yourself into.
Maybe we need to refactor the
CI once more: https://ci.nodejs.org/job/node-test-pull-request/7043/