Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove unneeded eslint-disable comment #11679

Closed
wants to merge 1 commit into from

Conversation

@Trott
Copy link
Member

commented Mar 3, 2017

test-url-format has the max-len rule disabled by a comment but doesn't
have any lines that violate the max-len rule. Remove the comment.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test url

@Trott Trott added test url labels Mar 3, 2017

@hiroppy
hiroppy approved these changes Mar 3, 2017
@cjihrig
cjihrig approved these changes Mar 3, 2017
@gibfahn
gibfahn approved these changes Mar 3, 2017
Copy link
Member

left a comment

LGTM, although while you're here you could capitalize and punctuate the comment on L6

 // some extra formatting tests, just to verify
 // that it'll format slightly wonky content to a valid url.
test: clean up comments in test-url-format
test-url-format has the max-len rule disabled by a comment but doesn't
have any lines that violate the max-len lint rule. Remove the comment.

Reformat other comments for capitalization, punctuation, and updated
URLs.

@Trott Trott force-pushed the Trott:max-len branch to 9132024 Mar 4, 2017

@Trott

This comment has been minimized.

Copy link
Member Author

commented Mar 4, 2017

LGTM, although while you're here you could capitalize and punctuate the comment on L6

Cleaned up a few comments. Thanks.

@hiroppy

This comment has been minimized.

@gibfahn
gibfahn approved these changes Mar 4, 2017
@watilde
watilde approved these changes Mar 4, 2017
Trott added a commit to Trott/io.js that referenced this pull request Mar 6, 2017
test: clean up comments in test-url-format
test-url-format has the max-len rule disabled by a comment but doesn't
have any lines that violate the max-len lint rule. Remove the comment.

Reformat other comments for capitalization, punctuation, and updated
URLs.

PR-URL: nodejs#11679
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
@Trott

This comment has been minimized.

Copy link
Member Author

commented Mar 6, 2017

Landed in 60c8115

@Trott Trott closed this Mar 6, 2017

@evanlucas

This comment has been minimized.

Copy link
Member

commented Mar 7, 2017

This is not landing cleanly on v7.x-staging. Feel free to send a backport PR. Thanks!

@jasnell jasnell referenced this pull request Apr 4, 2017
@gibfahn gibfahn referenced this pull request Jun 15, 2017
2 of 3 tasks complete
@gibfahn

This comment has been minimized.

Copy link
Member

commented Jun 17, 2017

Should this be backported to v6.x-staging? If yes please follow the guide and raise a backport PR, if no let me know or add the dont-land-on label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.