Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: make process.env work with symbols for in/delete #11709

Closed
wants to merge 1 commit into from

Conversation

@TimothyGu
Copy link
Member

commented Mar 6, 2017

The getter for process.env already allows symbols to be used, and in operator as a read-only operator can do the same.

delete a[b] operator in ES always returns true without doing anything when b in a === false. Allow symbols in the deleter accordingly.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

process

src: make process.env work with symbols for in/delete
The getter for process.env already allows symbols to be used, and `in`
operator as a read-only operator can do the same.

`delete a[b]` operator in ES always returns `true` without doing
anything when `b in a === false`. Allow symbols in the deleter
accordingly.
@cjihrig
cjihrig approved these changes Mar 6, 2017
@jasnell
jasnell approved these changes Mar 6, 2017
@TimothyGu

This comment has been minimized.

Copy link
Member Author

commented Mar 7, 2017

Removed semver-major since the change is backwards-compatible (it only allows more cases than it did before). Plus, the PR that made it necessary is only in master (#9446), not in any release staging branches.

@TimothyGu TimothyGu removed the semver-major label Mar 7, 2017

@TimothyGu

This comment has been minimized.

Copy link
Member Author

commented Mar 8, 2017

@mscdex Just making sure, you are okay with my taking off semver-major right?

If there are no more objections I'll land this tomorrow.

@TimothyGu

This comment has been minimized.

Copy link
Member Author

commented Mar 10, 2017

Landed in e2f151f

@TimothyGu TimothyGu closed this Mar 10, 2017

@TimothyGu TimothyGu deleted the TimothyGu:process-env branch Mar 10, 2017

TimothyGu added a commit that referenced this pull request Mar 10, 2017
src: make process.env work with symbols in/delete
The getter for process.env already allows symbols to be used, and `in`
operator as a read-only operator can do the same.

`delete a[b]` operator in ES always returns `true` without doing
anything when `b in a === false`. Allow symbols in the deleter
accordingly.

PR-URL: #11709
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
jungx098 added a commit to jungx098/node that referenced this pull request Mar 21, 2017
src: make process.env work with symbols in/delete
The getter for process.env already allows symbols to be used, and `in`
operator as a read-only operator can do the same.

`delete a[b]` operator in ES always returns `true` without doing
anything when `b in a === false`. Allow symbols in the deleter
accordingly.

PR-URL: nodejs#11709
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell jasnell referenced this pull request Apr 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.