New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark: fix punycode and get-ciphers benchmark #11720

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
8 participants
@bzoz
Contributor

bzoz commented Mar 6, 2017

I've missed two for loops without initialization in #9615. This adds missing i = 0 to those loops in punycode and get-ciphers benchmarks.

Sorry for the trouble.

/cc @mcollina @jasnell

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

benchmarks

benchmark: fix punycode and get-ciphers benchmark
Add missing 'i=0' from for-loops from punycode and get-ciphers
benchmarks.
@cjihrig

cjihrig approved these changes Mar 6, 2017

@jasnell

jasnell approved these changes Mar 6, 2017

@lpinca

lpinca approved these changes Mar 7, 2017

bzoz added a commit to janeasystems/node that referenced this pull request Mar 8, 2017

benchmark: remove benchmarks forced optimizations
Removes all instances of %OptimizeFunctionOnNextCall from benchmarks

Refs: nodejs#9615
Refs: nodejs#11720
@bzoz

This comment has been minimized.

Show comment
Hide comment
@bzoz

bzoz Mar 9, 2017

Contributor

Landed in 6df23fa

Contributor

bzoz commented Mar 9, 2017

Landed in 6df23fa

@bzoz bzoz closed this Mar 9, 2017

bzoz added a commit that referenced this pull request Mar 9, 2017

benchmark: fix punycode and get-ciphers benchmark
Add missing 'i=0' from for-loops from punycode and get-ciphers
benchmarks.

PR-URL: #11720
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

jungx098 added a commit to jungx098/node that referenced this pull request Mar 21, 2017

benchmark: fix punycode and get-ciphers benchmark
Add missing 'i=0' from for-loops from punycode and get-ciphers
benchmarks.

PR-URL: nodejs#11720
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

italoacasas added a commit to italoacasas/node that referenced this pull request Mar 21, 2017

benchmark: remove benchmarks forced optimizations
Removes all instances of %OptimizeFunctionOnNextCall from benchmarks

Refs: nodejs#9615
Refs: nodejs#11720

@jasnell jasnell referenced this pull request Apr 4, 2017

Closed

8.0.0 Release Proposal #12220

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment