New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: fix typos in node_lttng_provider.h #11723

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
7 participants
@bf4
Contributor

bf4 commented Mar 6, 2017

Follows #11189

To be considered a breaking change per #11189 (comment)

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Mar 6, 2017

Member

Can you format the first line of the commit message in accordance with the guidelines in the contribution guide?

Member

jasnell commented Mar 6, 2017

Can you format the first line of the commit message in accordance with the guidelines in the contribution guide?

@addaleax addaleax added the lib / src label Mar 6, 2017

@mscdex mscdex added semver-major and removed lib / src labels Mar 7, 2017

@bf4

This comment has been minimized.

Show comment
Hide comment
@bf4

bf4 Mar 7, 2017

Contributor

@jasnell

Can you format the first line of the commit message in accordance with the guidelines in the contribution guide?

I find the contribution guidelines kind of hard to parse.

The first line should be 50 characters or less and contain a short description of the change. All words in the description should be in lowercase with the exception of proper nouns, acronyms, and the ones that refer to code, like function/variable names. The description should be prefixed with the name of the changed subsystem and start with an imperative verb. Example: "net: add localAddress and localPort to Socket"

Are you asking me to format the commit message in lowercase? The PR description in lowercase? Or what subsystem would you call this? src: correct typos

If your patch fixes an open issue, you can add a reference to it at the end of the log. Use the Fixes: prefix and the full issue URL. For other references use Refs:. For example:

Should I add to the body of the commit message Refs: https://github.com/nodejs/node/pull/11189#discussion_r99509433

Contributor

bf4 commented Mar 7, 2017

@jasnell

Can you format the first line of the commit message in accordance with the guidelines in the contribution guide?

I find the contribution guidelines kind of hard to parse.

The first line should be 50 characters or less and contain a short description of the change. All words in the description should be in lowercase with the exception of proper nouns, acronyms, and the ones that refer to code, like function/variable names. The description should be prefixed with the name of the changed subsystem and start with an imperative verb. Example: "net: add localAddress and localPort to Socket"

Are you asking me to format the commit message in lowercase? The PR description in lowercase? Or what subsystem would you call this? src: correct typos

If your patch fixes an open issue, you can add a reference to it at the end of the log. Use the Fixes: prefix and the full issue URL. For other references use Refs:. For example:

Should I add to the body of the commit message Refs: https://github.com/nodejs/node/pull/11189#discussion_r99509433

@lpinca

This comment has been minimized.

Show comment
Hide comment
@lpinca

lpinca Mar 7, 2017

Member

Are you asking me to format the commit message in lowercase?

Yes. Something like src: fix typos in node_lttng_provider.h should work.
You can detail what typos have been fixed in the commit body but I think it's not necessary.
I would also not include the Refs: metadata as that comment does not provide any additional useful information imo, it doesn't harm though.

Member

lpinca commented Mar 7, 2017

Are you asking me to format the commit message in lowercase?

Yes. Something like src: fix typos in node_lttng_provider.h should work.
You can detail what typos have been fixed in the commit body but I think it's not necessary.
I would also not include the Refs: metadata as that comment does not provide any additional useful information imo, it doesn't harm though.

src: fix typos in node_lttng_provider.h
Is a semver-breaking change

Refs: #11189 (comment)

@bf4 bf4 changed the title from Breaking change, typo "s/Unkown/Unknown GC Type" to src: fix typos in node_lttng_provider.h Mar 7, 2017

@bf4

This comment has been minimized.

Show comment
Hide comment
@bf4

bf4 Mar 7, 2017

Contributor
Contributor

bf4 commented Mar 7, 2017

@bf4 bf4 referenced this pull request Mar 7, 2017

Closed

doc: make commit guidelines easier to reference #11732

2 of 2 tasks complete
@lpinca

lpinca approved these changes Mar 8, 2017

@jasnell

jasnell approved these changes Mar 8, 2017

@jasnell

This comment has been minimized.

Show comment
Hide comment
@cjihrig

cjihrig approved these changes Mar 9, 2017

@addaleax

This comment has been minimized.

Show comment
Hide comment
@addaleax

addaleax Mar 10, 2017

Member

Landed in 1125c8a, thanks for the PR!

Member

addaleax commented Mar 10, 2017

Landed in 1125c8a, thanks for the PR!

@addaleax addaleax closed this Mar 10, 2017

addaleax added a commit that referenced this pull request Mar 10, 2017

src: fix typos in node_lttng_provider.h
Is a semver-breaking change

Refs: #11189 (comment)
PR-URL: #11723
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

@bf4 bf4 deleted the bf4:correct_typos_breaking_change branch Mar 13, 2017

jungx098 added a commit to jungx098/node that referenced this pull request Mar 21, 2017

src: fix typos in node_lttng_provider.h
Is a semver-breaking change

Refs: nodejs#11189 (comment)
PR-URL: nodejs#11723
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

@jasnell jasnell referenced this pull request Apr 4, 2017

Closed

8.0.0 Release Proposal #12220

gibfahn added a commit that referenced this pull request Apr 22, 2017

doc: make commit guidelines easier to reference
- Can now link to 'Commit Guidelines' from pull requests
- Breaks up commit requirements and recommendations

PR-URL: #11732
Refs: #11723 (comment)
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>

evanlucas added a commit that referenced this pull request Apr 25, 2017

doc: make commit guidelines easier to reference
- Can now link to 'Commit Guidelines' from pull requests
- Breaks up commit requirements and recommendations

PR-URL: #11732
Refs: #11723 (comment)
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>

evanlucas added a commit that referenced this pull request May 1, 2017

doc: make commit guidelines easier to reference
- Can now link to 'Commit Guidelines' from pull requests
- Breaks up commit requirements and recommendations

PR-URL: #11732
Refs: #11723 (comment)
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>

evanlucas added a commit that referenced this pull request May 2, 2017

doc: make commit guidelines easier to reference
- Can now link to 'Commit Guidelines' from pull requests
- Breaks up commit requirements and recommendations

PR-URL: #11732
Refs: #11723 (comment)
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>

gibfahn added a commit that referenced this pull request May 16, 2017

doc: make commit guidelines easier to reference
- Can now link to 'Commit Guidelines' from pull requests
- Breaks up commit requirements and recommendations

PR-URL: #11732
Refs: #11723 (comment)
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>

MylesBorins added a commit that referenced this pull request May 18, 2017

doc: make commit guidelines easier to reference
- Can now link to 'Commit Guidelines' from pull requests
- Breaks up commit requirements and recommendations

PR-URL: #11732
Refs: #11723 (comment)
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>

andrew749 added a commit to michielbaird/node that referenced this pull request Jul 19, 2017

doc: make commit guidelines easier to reference
- Can now link to 'Commit Guidelines' from pull requests
- Breaks up commit requirements and recommendations

PR-URL: nodejs/node#11732
Refs: nodejs/node#11723 (comment)
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment