New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linkedlist: remove unused methods #11726

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
10 participants
@mscdex
Contributor

mscdex commented Mar 7, 2017

This should probably only land once lib/_linklist.js is removed to avoid any breakage. Since that private module has been (runtime) deprecated since v5.0.0, should it finally be removed in v8.0.0? If not, I can mark this as 'in progress' or similar until it is removed. Thoughts @nodejs/ctc?

CI: https://ci.nodejs.org/job/node-test-pull-request/6736/

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)
  • lib/src
@indutny

indutny approved these changes Mar 7, 2017

LGTM, as long as CI is happy.

@sam-github

This comment has been minimized.

Show comment
Hide comment
@sam-github

sam-github Mar 7, 2017

Member

I think the entire module should be removed, as you say, its been runtime deprecated since 5.x, 8.x is a good time to remove it.

Member

sam-github commented Mar 7, 2017

I think the entire module should be removed, as you say, its been runtime deprecated since 5.x, 8.x is a good time to remove it.

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Mar 7, 2017

Member

@ChALkeR ... can you check to see if there is any ecosystem usage of _linked_list remaining? I'm +1 to removing it so long as it doesn't break anything (keeping in mind, of course, the fact that a stub should remain in order to keep malicious userland folks from jumping on the name)

Member

jasnell commented Mar 7, 2017

@ChALkeR ... can you check to see if there is any ecosystem usage of _linked_list remaining? I'm +1 to removing it so long as it doesn't break anything (keeping in mind, of course, the fact that a stub should remain in order to keep malicious userland folks from jumping on the name)

@cjihrig

LGTM if the ecosystem is not using it. I'd also be +1 to removing it completely if it's not being used.

@mscdex mscdex added this to the 8.0.0 milestone Mar 14, 2017

@mscdex

This comment has been minimized.

Show comment
Hide comment
Contributor

mscdex commented Mar 21, 2017

@rvagg

This comment has been minimized.

Show comment
Hide comment
@rvagg

rvagg Mar 22, 2017

Member

lgtm

Member

rvagg commented Mar 22, 2017

lgtm

@mscdex

This comment has been minimized.

Show comment
Hide comment
@mscdex

mscdex Mar 22, 2017

Contributor

To those who approved this.... is that an approval of this PR as-is or approval of just removing the module entirely? @indutny @cjihrig @jasnell @rvagg

Contributor

mscdex commented Mar 22, 2017

To those who approved this.... is that an approval of this PR as-is or approval of just removing the module entirely? @indutny @cjihrig @jasnell @rvagg

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Mar 22, 2017

Member
Member

jasnell commented Mar 22, 2017

@cjihrig

This comment has been minimized.

Show comment
Hide comment
@cjihrig

cjihrig Mar 22, 2017

Contributor

What @jasnell said.

Contributor

cjihrig commented Mar 22, 2017

What @jasnell said.

@mscdex

This comment has been minimized.

Show comment
Hide comment
@mscdex

mscdex Mar 29, 2017

Contributor

I've decided to do the _linklist removal separately in #12113. I can combine these two if there is interest in doing so.

Contributor

mscdex commented Mar 29, 2017

I've decided to do the _linklist removal separately in #12113. I can combine these two if there is interest in doing so.

jasnell added a commit that referenced this pull request Apr 4, 2017

linkedlist: remove unused methods
PR-URL: #11726
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Apr 4, 2017

Member

Landed in b40dab5

Member

jasnell commented Apr 4, 2017

Landed in b40dab5

@jasnell jasnell closed this Apr 4, 2017

@mscdex mscdex deleted the mscdex:linkedlist-remove-unused-methods branch Apr 4, 2017

@jasnell jasnell referenced this pull request Apr 4, 2017

Closed

8.0.0 Release Proposal #12220

@Trott Trott removed the ctc-review label Apr 6, 2017

@yosuke-furukawa yosuke-furukawa referenced this pull request May 4, 2017

Closed

http2: fix res.setHeader to update linkedlist APIs #75

2 of 2 tasks complete
@ChALkeR

This comment has been minimized.

Show comment
Hide comment
@ChALkeR

ChALkeR May 4, 2017

Member

Sorry, it looks like I forgot this one.

It's completely ok to change, the public version of the module have been runtime-deprecated in #3078 and removed in #12113. The (old) usage data is at #3078 (comment) and was about 17 packages.

Member

ChALkeR commented May 4, 2017

Sorry, it looks like I forgot this one.

It's completely ok to change, the public version of the module have been runtime-deprecated in #3078 and removed in #12113. The (old) usage data is at #3078 (comment) and was about 17 packages.

@ChALkeR

Late LGTM :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment