Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add hasCrypto check to tls-legacy-deprecated #11747

Closed

Conversation

@danbev
Copy link
Member

commented Mar 8, 2017

Currently test-tls-legacy-deprecated will fail if node
was built using --without-ssl. This commit adds a check to
verify that crypto support exists and if not skip this test.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

test: add hasCrypto check to tls-legacy-deprecated
Currently test-tls-legacy-deprecated will fail if node
was built using --without-ssl. This commit adds a check to
verify is crypto support exists and if not skip this test.
@danbev

This comment has been minimized.

Copy link
Member Author

commented Mar 8, 2017

@jasnell
jasnell approved these changes Mar 8, 2017
Copy link
Member

left a comment

whoops.. good catch.

@cjihrig
cjihrig approved these changes Mar 9, 2017
danbev added a commit to danbev/node that referenced this pull request Mar 10, 2017
test: add hasCrypto check to tls-legacy-deprecated
Currently test-tls-legacy-deprecated will fail if node
was built using --without-ssl. This commit adds a check to
verify is crypto support exists and if not skip this test.

PR-URL: nodejs#11747
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@danbev

This comment has been minimized.

Copy link
Member Author

commented Mar 10, 2017

Landed in b98004b

@danbev danbev closed this Mar 10, 2017

jungx098 added a commit to jungx098/node that referenced this pull request Mar 21, 2017
test: add hasCrypto check to tls-legacy-deprecated
Currently test-tls-legacy-deprecated will fail if node
was built using --without-ssl. This commit adds a check to
verify is crypto support exists and if not skip this test.

PR-URL: nodejs#11747
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@italoacasas

This comment has been minimized.

Copy link
Member

commented Mar 21, 2017

This PR need backport to v7

@danbev

This comment has been minimized.

Copy link
Member Author

commented Apr 19, 2017

@italoacasas Sorry again (I've had an issue with my email filter which has cause me to miss some messages, not intentional). Should I still backport this issue?

@danbev danbev deleted the danbev:crypto-check-test-tls-legacy-deprecated branch Apr 20, 2017

@gibfahn

This comment has been minimized.

Copy link
Member

commented Jun 14, 2017

Should I still backport this issue?

No need (although I assume you already know that!) There won't be another 7.x release, and this is in Node 8.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.