Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: include all stdio strings for fork() #11783

Closed
wants to merge 1 commit into from

Conversation

@Trott
Copy link
Member

commented Mar 10, 2017

test-child-process-fork-stdio-string-variant was only testing 'pipe' for
its stdio value. Add inherit and ignore.

Also added a common.mustCall() to verify that the message event is
triggered.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test child_process

test/parallel/test-child-process-fork-stdio-string-variant.js Outdated

assert.throws(() => fork(childScript, malFormedOpts), errorRegexp);

const child = fork(childScript, stringOpts);
function test(stringVariant) {
const child = fork(childScript, {stdio: 'pipe'});

This comment has been minimized.

Copy link
@lpinca

lpinca Mar 10, 2017

Member

The options object should be {stdio: stringVariant}.

This comment has been minimized.

Copy link
@Trott

Trott Mar 10, 2017

Author Member

<facepalm>...fixing...

@cjihrig
Copy link
Contributor

left a comment

LGTM with @lpinca's nit addressed.

test: include all stdio strings for fork()
test-child-process-fork-stdio-string-variant was only testing 'pipe' for
its `stdio` value. Add `inherit` and `ignore`.

Also added a `common.mustCall()` to verify that the `message` event is
triggered.

@Trott Trott force-pushed the Trott:ignore branch to 92a1f95 Mar 10, 2017

@Trott

This comment has been minimized.

Copy link
Member Author

commented Mar 10, 2017

@lpinca
lpinca approved these changes Mar 10, 2017
@Trott

This comment has been minimized.

Copy link
Member Author

commented Mar 13, 2017

Landed in 78cdd4b

@Trott Trott closed this Mar 13, 2017

Trott added a commit to Trott/io.js that referenced this pull request Mar 13, 2017
test: include all stdio strings for fork()
test-child-process-fork-stdio-string-variant was only testing 'pipe' for
its `stdio` value. Add `inherit` and `ignore`.

Also added a `common.mustCall()` to verify that the `message` event is
triggered.

PR-URL: nodejs#11783
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
@italoacasas

This comment has been minimized.

Copy link
Member

commented Mar 14, 2017

This is not landing clearly in v7 staging, @Trott can backport?

@Trott

This comment has been minimized.

Copy link
Member Author

commented Mar 14, 2017

@italoacasas This depends on #10866 which is semver-major. Adding dont-land-on-* labels.

jungx098 added a commit to jungx098/node that referenced this pull request Mar 21, 2017
test: include all stdio strings for fork()
test-child-process-fork-stdio-string-variant was only testing 'pipe' for
its `stdio` value. Add `inherit` and `ignore`.

Also added a `common.mustCall()` to verify that the `message` event is
triggered.

PR-URL: nodejs#11783
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
@jasnell jasnell referenced this pull request Apr 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.