Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: remove an unused internal module `assertPort` #11812

Closed
wants to merge 1 commit into from

Conversation

@watilde
Copy link
Member

commented Mar 12, 2017

Since a module assertPort in lib/internal/net.js is not used anymore, we can remove it. The coverage of lib/internal/net.js will be 100% with this.

See also: #11667

Checklist
  • make -j4 test
  • commit message follows commit guidelines
Affected core subsystem(s)

net

net: remove an unused internal module `assertPort`
A module `assertPort` in `lib/internal/net.js` is not used anymore.

Refs: #11667
@targos
targos approved these changes Mar 12, 2017
@JacksonTian

This comment has been minimized.

Copy link
Contributor

commented Mar 12, 2017

LGTM

@lpinca
lpinca approved these changes Mar 12, 2017
@mscdex

This comment has been minimized.

Copy link
Contributor

commented Mar 12, 2017

@watilde

This comment has been minimized.

Copy link
Member Author

commented Mar 13, 2017

Probably, the CI errors caused by the same reason with this: #11817 (comment). I will retry it.

@watilde

This comment has been minimized.

Copy link
Member Author

commented Mar 13, 2017

@watilde watilde referenced this pull request Mar 13, 2017
3 of 3 tasks complete
@watilde

This comment has been minimized.

Copy link
Member Author

commented Mar 14, 2017

Landed in 879d666

@watilde watilde closed this Mar 14, 2017

@watilde watilde deleted the watilde:feature/assertPort branch Mar 14, 2017

watilde added a commit that referenced this pull request Mar 14, 2017
net: remove an unused internal module `assertPort`
A module `assertPort` in `lib/internal/net.js` is not used anymore.

Refs: #11667
PR-URL: #11812
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
jungx098 added a commit to jungx098/node that referenced this pull request Mar 21, 2017
net: remove an unused internal module `assertPort`
A module `assertPort` in `lib/internal/net.js` is not used anymore.

Refs: nodejs#11667
PR-URL: nodejs#11812
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@italoacasas

This comment has been minimized.

Copy link
Member

commented Mar 21, 2017

This PR needs backport to v7

@jasnell jasnell referenced this pull request Apr 4, 2017
watilde added a commit to watilde/node that referenced this pull request May 5, 2017
net: remove an unused internal module `assertPort`
A module `assertPort` in `lib/internal/net.js` is not used anymore.

Refs: nodejs#11667
PR-URL: nodejs#11812
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
watilde added a commit that referenced this pull request May 12, 2017
net: remove an unused internal module `assertPort`
A module `assertPort` in `lib/internal/net.js` is not used anymore.

Refs: #11667
PR-URL: #11812
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@gibfahn gibfahn referenced this pull request Jun 15, 2017
2 of 3 tasks complete
@gibfahn

This comment has been minimized.

Copy link
Member

commented Jun 17, 2017

@watilde should this be backported to v6.x? 33ea7a2 applies cleanly, so if it should I'll cherry-pick it directly.

@MylesBorins

This comment has been minimized.

Copy link
Member

commented Jul 17, 2017

ping @watilde

1 similar comment
@MylesBorins

This comment has been minimized.

Copy link
Member

commented Aug 14, 2017

ping @watilde

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
You can’t perform that action at this time.