Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
build: add cpp linting to windows build #11856
This PR adds cpp linting to windows build script. After this change,
Affected core subsystem(s)
I am actually seeing linting failures on my machine when following steps in CONTRIBUTING.md.
More specifically, the failure is regarding header_guard where the full file path is used for comparison. For example, for file "C:\sample\node\src\async-wrap.h", linter is expecting
More of a question, I am wondering if specifying a
referenced this pull request
Mar 16, 2017
added a commit
this pull request
Mar 17, 2017
@liusy182 So at the moment your Git author name and email address are set to:
People usually choose to use their full names for commits. To set your name globally (if you want to) you can do:
git config --global user.name "Siyuan Liu"
@liusy182 also your email address isn't associated with your GitHub account, so you probably want to either change your email address (see below), or add it as an alternative in your GitHub email settings.
git config --global user.email "email@example.com"
Otherwise you get "Unrecognised author" in the commit log.