Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: remove explicit UTF-8 validity check in url #11859

Closed
wants to merge 1 commit into from

Conversation

@TimothyGu
Copy link
Member

commented Mar 15, 2017

This step was never part of the URL Standard's host parser algorithm, and is rendered unnecessary after errors from ToASCII are no longer ignored.

Refs: c2a302c "src: do not ignore IDNA conversion error"
Refs: https://url.spec.whatwg.org/#concept-host-parser

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src, url

@TimothyGu

This comment has been minimized.

Copy link
Member Author

commented Mar 15, 2017

@jasnell
Copy link
Member

left a comment

Oh! Thank you! You just crossed an item off my todo list for me. Definitely appreciate that!

@TimothyGu TimothyGu force-pushed the TimothyGu:url-utf8 branch Mar 16, 2017

src: remove explicit UTF-8 validity check in url
This step was never part of the URL Standard's host parser algorithm,
and is rendered unnecessary after IDNA errors are no longer ignored.

PR-URL: #11859
Refs: c2a302c "src: do not ignore IDNA conversion error"
Refs: https://url.spec.whatwg.org/#concept-host-parser
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

@TimothyGu TimothyGu force-pushed the TimothyGu:url-utf8 branch to 7edcf47 Mar 16, 2017

@TimothyGu

This comment has been minimized.

Copy link
Member Author

commented Mar 16, 2017

Removed the now unused header inclusion too. Will land when CI passes.

CI: https://ci.nodejs.org/job/node-test-pull-request/6892/

@TimothyGu

This comment has been minimized.

Copy link
Member Author

commented Mar 16, 2017

Landed in d099f8e.

@TimothyGu TimothyGu closed this Mar 16, 2017

@TimothyGu TimothyGu deleted the TimothyGu:url-utf8 branch Mar 16, 2017

TimothyGu added a commit that referenced this pull request Mar 16, 2017
src: remove explicit UTF-8 validity check in url
This step was never part of the URL Standard's host parser algorithm,
and is rendered unnecessary after IDNA errors are no longer ignored.

PR-URL: #11859
Refs: c2a302c "src: do not ignore IDNA conversion error"
Refs: https://url.spec.whatwg.org/#concept-host-parser
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
jungx098 added a commit to jungx098/node that referenced this pull request Mar 21, 2017
src: remove explicit UTF-8 validity check in url
This step was never part of the URL Standard's host parser algorithm,
and is rendered unnecessary after IDNA errors are no longer ignored.

PR-URL: nodejs#11859
Refs: c2a302c "src: do not ignore IDNA conversion error"
Refs: https://url.spec.whatwg.org/#concept-host-parser
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@italoacasas

This comment has been minimized.

Copy link
Member

commented Mar 21, 2017

Need backport to v7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
8 participants
You can’t perform that action at this time.