New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark: add final clean-up to module-loader.js #11924

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
6 participants
@vsemozhetbyt
Member

vsemozhetbyt commented Mar 19, 2017

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

benchmark, module

Currently, module-loader.js cleans up its temp directory only before each benchmark run. So after the last run, a tmp directory with 50,000 subdirectories and 100,000 files remains in the benchmark directory. A second final clean-up does not add much more time to overall benchmark duration because it reduces the time for each next initialization, while benchmark directory remains clean after the last run.

@vsemozhetbyt vsemozhetbyt added the module label Mar 20, 2017

@vsemozhetbyt

This comment has been minimized.

Show comment
Hide comment

jasnell added a commit that referenced this pull request Mar 22, 2017

benchmark: add final clean-up to module-loader.js
PR-URL: #11924
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Mar 22, 2017

Member

Landed in ae8a869

Member

jasnell commented Mar 22, 2017

Landed in ae8a869

@jasnell jasnell closed this Mar 22, 2017

@vsemozhetbyt vsemozhetbyt deleted the vsemozhetbyt:module-loader branch Mar 22, 2017

@MylesBorins

This comment has been minimized.

Show comment
Hide comment
@MylesBorins

MylesBorins Mar 28, 2017

Member

this will need to be manually backported to v7.x

Member

MylesBorins commented Mar 28, 2017

this will need to be manually backported to v7.x

@vsemozhetbyt

This comment has been minimized.

Show comment
Hide comment
Member

vsemozhetbyt commented Mar 28, 2017

@jasnell jasnell referenced this pull request Apr 4, 2017

Closed

8.0.0 Release Proposal #12220

@gibfahn gibfahn referenced this pull request Jun 15, 2017

Closed

Auditing for 6.11.1 #230

2 of 3 tasks complete
@gibfahn

This comment has been minimized.

Show comment
Hide comment
@gibfahn

gibfahn Jun 17, 2017

Member

@vsemozhetbyt, I landed 211dd16 on v6.x-staging, let me know if that was a mistake.

Member

gibfahn commented Jun 17, 2017

@vsemozhetbyt, I landed 211dd16 on v6.x-staging, let me know if that was a mistake.

@vsemozhetbyt

This comment has been minimized.

Show comment
Hide comment
@vsemozhetbyt

vsemozhetbyt Jun 17, 2017

Member

@gibfahn I cannot imagine any cause this can be wrong.

Member

vsemozhetbyt commented Jun 17, 2017

@gibfahn I cannot imagine any cause this can be wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment