Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: minor fixups for REPL eval tests #11946

Closed
wants to merge 1 commit into from

Conversation

@addaleax
Copy link
Member

commented Mar 20, 2017

The process.on("exit") event handlers are unnecessary, so it’s okay
to drop them.

Ref: #11871

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test,repl

test: minor fixups for REPL eval tests
The `process.on("exit")` event handlers are unnecessary, so it’s okay
to drop them.

Ref: #11871
@Fishrock123
Copy link
Member

left a comment

jasnell added a commit that referenced this pull request Mar 22, 2017
test: minor fixups for REPL eval tests
The `process.on("exit")` event handlers are unnecessary, so it’s okay
to drop them.

PR-URL: #11946
Ref: #11871
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@jasnell

This comment has been minimized.

Copy link
Member

commented Mar 22, 2017

Landed in 64d0a73

@jasnell jasnell closed this Mar 22, 2017

@jasnell jasnell referenced this pull request Apr 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.