New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: support Uint8Array prime in createDH #11983

wants to merge 3 commits into
base: master


None yet
5 participants

addaleax commented Mar 22, 2017

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

LGTM modulo style nits.

Show outdated Hide outdated lib/crypto.js
Show outdated Hide outdated test/parallel/test-crypto-dh.js

lpinca approved these changes Mar 24, 2017

Show outdated Hide outdated test/parallel/test-crypto-dh.js

This comment has been minimized.

Show comment
Hide comment

addaleax Mar 27, 2017


Landed in 0db49fe


addaleax commented Mar 27, 2017

Landed in 0db49fe

@addaleax addaleax closed this Mar 27, 2017

@addaleax addaleax deleted the addaleax:crypto-uint8array branch Mar 27, 2017

addaleax added a commit that referenced this pull request Mar 27, 2017

crypto: support Uint8Array prime in createDH
PR-URL: #11983
Reviewed-By: James M Snell <>
Reviewed-By: Luigi Pinca <>
Reviewed-By: Ben Noordhuis <>

@jasnell jasnell referenced this pull request Apr 4, 2017


8.0.0 Release Proposal #12220

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment