Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add internal/socket_list tests #11989

Closed
wants to merge 1 commit into from

Conversation

@DavidCai1993
Copy link
Member

commented Mar 22, 2017

Add tests of internal/socket_list.js and increase its coverage.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@Fishrock123

This comment has been minimized.

jasnell added a commit that referenced this pull request Mar 24, 2017
test: add internal/socket_list tests
PR-URL: #11989
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell

This comment has been minimized.

Copy link
Member

commented Mar 24, 2017

Landed in 4929d12

@MylesBorins

This comment has been minimized.

Copy link
Member

commented Mar 28, 2017

These tests are currently failing on v7.x and will need to be manually backported

@DavidCai1993

This comment has been minimized.

Copy link
Member Author

commented Mar 29, 2017

OK, I'll submit another PR to backport it.

@jasnell jasnell referenced this pull request Apr 4, 2017
@gibfahn gibfahn referenced this pull request Jun 15, 2017
2 of 3 tasks complete
@gibfahn

This comment has been minimized.

Copy link
Member

commented Jun 17, 2017

Landed b997e62 on v6.x-staging, LMK if I shouldn't have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.