New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: adds options for cpp linting to help section of Windows build script #11992

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
9 participants
@brennemo
Contributor

brennemo commented Mar 22, 2017

Adds options for cpp linting to help section of Windows build script

Fixes: #11971

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
@gibfahn

This comment has been minimized.

Show comment
Hide comment
@gibfahn
Member

gibfahn commented Mar 22, 2017

cc/ @refack

@gibfahn gibfahn added the windows label Mar 22, 2017

@vsemozhetbyt

This comment has been minimized.

Show comment
Hide comment
@vsemozhetbyt

vsemozhetbyt Mar 22, 2017

Member

@brennemo Thank you for the contribution. A nit: it seems the commit title exceed required 50 characters and lacks subsystem prefix (@gibfahn, should it be doc or build?). Could you amend it, using also the mentioned lowercase and imperative verb?

Member

vsemozhetbyt commented Mar 22, 2017

@brennemo Thank you for the contribution. A nit: it seems the commit title exceed required 50 characters and lacks subsystem prefix (@gibfahn, should it be doc or build?). Could you amend it, using also the mentioned lowercase and imperative verb?

@refack

This comment has been minimized.

Show comment
Hide comment
@refack

refack Mar 22, 2017

Member

LGTM pending @vsemozhetbyt's comment
(not being condescending, but it should be simple then git push -f)

Member

refack commented Mar 22, 2017

LGTM pending @vsemozhetbyt's comment
(not being condescending, but it should be simple then git push -f)

@gibfahn

This comment has been minimized.

Show comment
Hide comment
@gibfahn

gibfahn Mar 22, 2017

Member

Good point @vsemozhetbyt , @brennemo maybe something like this for the commit message:

build: add lint option to vcbuild.bat help

Also your name in git is currently:

Morgan <brennemo@oregonstate.edu>

People usually choose to use their full names for commits. To set your name globally you can do:

git config --global user.name "Morgan Brenner"

To change the author and commit message you can do:

git commit --amend --author="Morgan Brenner <brennemo@oregonstate.edu>"
# Edit commit message when it pops up
git push --force-with-lease
Member

gibfahn commented Mar 22, 2017

Good point @vsemozhetbyt , @brennemo maybe something like this for the commit message:

build: add lint option to vcbuild.bat help

Also your name in git is currently:

Morgan <brennemo@oregonstate.edu>

People usually choose to use their full names for commits. To set your name globally you can do:

git config --global user.name "Morgan Brenner"

To change the author and commit message you can do:

git commit --amend --author="Morgan Brenner <brennemo@oregonstate.edu>"
# Edit commit message when it pops up
git push --force-with-lease
@brennemo

This comment has been minimized.

Show comment
Hide comment
@brennemo

brennemo Mar 23, 2017

Contributor

Sure, I amended the author to add my last name and updated the commit message.

Contributor

brennemo commented Mar 23, 2017

Sure, I amended the author to add my last name and updated the commit message.

@vsemozhetbyt

This comment has been minimized.

Show comment
Hide comment
Member

vsemozhetbyt commented Mar 23, 2017

jasnell added a commit that referenced this pull request Mar 24, 2017

build: add lint option to vcbuild.bat help
PR-URL: #11992
Fixes: #11971
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Mar 24, 2017

Member

Landed in a8a042a

Member

jasnell commented Mar 24, 2017

Landed in a8a042a

@jasnell jasnell closed this Mar 24, 2017

MylesBorins added a commit that referenced this pull request Mar 28, 2017

build: add lint option to vcbuild.bat help
PR-URL: #11992
Fixes: #11971
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

@MylesBorins MylesBorins referenced this pull request Mar 28, 2017

Merged

V7.8.0 proposal #12104

@italoacasas italoacasas referenced this pull request Apr 10, 2017

Merged

v7.9.0 Release Proposal #12319

2 of 2 tasks complete

@MylesBorins MylesBorins referenced this pull request Apr 18, 2017

Closed

build: add cpp linting to windows build #11856

2 of 4 tasks complete
@MylesBorins

This comment has been minimized.

Show comment
Hide comment
@MylesBorins

MylesBorins May 15, 2017

Member

should this be backported?

Member

MylesBorins commented May 15, 2017

should this be backported?

@refack

This comment has been minimized.

Show comment
Hide comment
@refack

refack May 15, 2017

Member

I'm +0.1 (it's a tiny documentation change, so little gain little risk)
It's just a "docs bug fix" for #11856

Member

refack commented May 15, 2017

I'm +0.1 (it's a tiny documentation change, so little gain little risk)
It's just a "docs bug fix" for #11856

@gibfahn gibfahn referenced this pull request Jun 15, 2017

Closed

Auditing for 6.11.1 #230

2 of 3 tasks complete
@gibfahn

This comment has been minimized.

Show comment
Hide comment
@gibfahn

gibfahn Jun 17, 2017

Member

@refack would you mind backporting this and 379eec3 to v6.x-staging?

guide

Member

gibfahn commented Jun 17, 2017

@refack would you mind backporting this and 379eec3 to v6.x-staging?

guide

@refack

This comment has been minimized.

Show comment
Hide comment
@refack

refack Jun 17, 2017

Member

@refack would you mind backporting this and 379eec3 to v6.x-staging?

Ack.
Re guide: #13749

Member

refack commented Jun 17, 2017

@refack would you mind backporting this and 379eec3 to v6.x-staging?

Ack.
Re guide: #13749

refack added a commit to refack/node that referenced this pull request Aug 22, 2017

build: add lint option to vcbuild.bat help
PR-URL: nodejs#11992
Fixes: nodejs#11971
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

@refack refack referenced this pull request Aug 22, 2017

Closed

[v6.x backport] build: enable cpplint on windows #14879

2 of 2 tasks complete

MylesBorins added a commit that referenced this pull request Sep 19, 2017

build: add lint option to vcbuild.bat help
180bec1
PR-URL: #11992
Fixes: #11971
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

@MylesBorins MylesBorins referenced this pull request Sep 20, 2017

Merged

v6.11.4 proposal #15506

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment