tools: add missing #include "unicode/putil.h" #12078

Closed
wants to merge 0 commits into
from

Conversation

Projects
None yet
7 participants
@srl295
Member

srl295 commented Mar 27, 2017

  • we use a function in "unicode/putil.h"
  • at present, this header is indirectly included,
    but this will change in ICU 59
  • no impact on past ICUs.
  • this is an exact analog to #11753
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows
Affected core subsystem(s)
  • tools

@srl295 srl295 self-assigned this Mar 27, 2017

@srl295

This comment has been minimized.

Show comment
Hide comment
@srl295

srl295 Mar 27, 2017

Member

needed for ICU 59 bump: #12077

Member

srl295 commented Mar 27, 2017

needed for ICU 59 bump: #12077

@cjihrig

LGTM. Can you mention, in the commit log, the function that is used.

@srl295

This comment has been minimized.

Show comment
Hide comment
@srl295

srl295 Mar 29, 2017

Member

@cjihrig thanks, done and rebased.

Member

srl295 commented Mar 29, 2017

@cjihrig thanks, done and rebased.

@srl295 srl295 removed the in progress label Mar 30, 2017

@srl295 srl295 closed this Mar 30, 2017

srl295 added a commit that referenced this pull request Mar 30, 2017

tools: add missing #include "unicode/putil.h"
* we use u_setDataDirectory() in "unicode/putil.h"
* at present, this header is indirectly included,
  but this will change in ICU 59
* no impact on past ICUs.
* this is an exact analog to #11753

PR-URL: #12078
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>

@srl295 srl295 deleted the srl295:fix-iculslocs branch Mar 30, 2017

@srl295

This comment has been minimized.

Show comment
Hide comment
@srl295

srl295 Mar 30, 2017

Member

Landed in b084907

Member

srl295 commented Mar 30, 2017

Landed in b084907

@jasnell jasnell referenced this pull request Apr 4, 2017

Closed

8.0.0 Release Proposal #12220

italoacasas added a commit to italoacasas/node that referenced this pull request Apr 10, 2017

tools: add missing #include "unicode/putil.h"
* we use u_setDataDirectory() in "unicode/putil.h"
* at present, this header is indirectly included,
  but this will change in ICU 59
* no impact on past ICUs.
* this is an exact analog to nodejs#11753

PR-URL: nodejs#12078
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>

@italoacasas italoacasas referenced this pull request Apr 10, 2017

Merged

v7.9.0 Release Proposal #12319

2 of 2 tasks complete
@MylesBorins

This comment has been minimized.

Show comment
Hide comment
Member

MylesBorins commented Apr 18, 2017

@srl295 lts?

@gibfahn

This comment has been minimized.

Show comment
Hide comment
@gibfahn

gibfahn May 16, 2017

Member

@srl295 given this:

no impact on past ICUs.

Does that mean that this isn't necessary on v6.x?

Member

gibfahn commented May 16, 2017

@srl295 given this:

no impact on past ICUs.

Does that mean that this isn't necessary on v6.x?

@gibfahn gibfahn referenced this pull request in nodejs/Release Jun 15, 2017

Closed

Auditing for 6.11.1 #230

2 of 3 tasks complete
@gibfahn

This comment has been minimized.

Show comment
Hide comment
Member

gibfahn commented Jun 17, 2017

ping @srl295

@MylesBorins

This comment has been minimized.

Show comment
Hide comment
Member

MylesBorins commented Jul 17, 2017

ping @srl295

@MylesBorins

This comment has been minimized.

Show comment
Hide comment
Member

MylesBorins commented Aug 14, 2017

ping @srl295

@srl295

This comment has been minimized.

Show comment
Hide comment
@srl295

srl295 Aug 14, 2017

Member

☹️ sorry, yes ,it should be backported if we want to use ICU 59 on past Nodes.
So its not necessary, but it can be helpful.

Member

srl295 commented Aug 14, 2017

☹️ sorry, yes ,it should be backported if we want to use ICU 59 on past Nodes.
So its not necessary, but it can be helpful.

MylesBorins added a commit that referenced this pull request Aug 14, 2017

tools: add missing #include "unicode/putil.h"
* we use u_setDataDirectory() in "unicode/putil.h"
* at present, this header is indirectly included,
  but this will change in ICU 59
* no impact on past ICUs.
* this is an exact analog to #11753

PR-URL: #12078
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>

MylesBorins added a commit that referenced this pull request Aug 16, 2017

tools: add missing #include "unicode/putil.h"
* we use u_setDataDirectory() in "unicode/putil.h"
* at present, this header is indirectly included,
  but this will change in ICU 59
* no impact on past ICUs.
* this is an exact analog to #11753

PR-URL: #12078
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>

@MylesBorins MylesBorins referenced this pull request Aug 16, 2017

Merged

v6.11.3-proposal #14852

MylesBorins added a commit that referenced this pull request Sep 5, 2017

2017-09-05, Version 6.11.3 'Boron' (LTS)
This LTS release comes with 152 commits. This includes 75 which are
test related, 25 which are doc related, 21 which are build / tool
related and 3 commits which are updates to dependencies.

Notable Changes:

* build:
 - Codesigning is fixed on macOS (Evan Lucas)
   #14179
* deps:
 - Snapshots are turned back on!!! (Yang Guo)
   #14385
* path:
 - win32 volume-relative paths are working again! (Timothy Gu)
   #14440
* tools:
 - v6.x can now build with ICU 59 (Steven R. Loomis)
   #12078

PR-URL: #14852

MylesBorins added a commit that referenced this pull request Sep 5, 2017

2017-09-05, Version 6.11.3 'Boron' (LTS)
This LTS release comes with 152 commits. This includes 75 which are
test related, 25 which are doc related, 21 which are build / tool
related and 3 commits which are updates to dependencies.

Notable Changes:

* build:
 - Codesigning is fixed on macOS (Evan Lucas)
   #14179
* deps:
 - Snapshots are turned back on!!! (Yang Guo)
   #14385
* path:
 - win32 volume-relative paths are working again! (Timothy Gu)
   #14440
* tools:
 - v6.x can now build with ICU 59 (Steven R. Loomis)
   #12078

PR-URL: #14852

MylesBorins added a commit that referenced this pull request Sep 5, 2017

2017-09-05, Version 6.11.3 'Boron' (LTS)
This LTS release comes with 152 commits. This includes 75 which are
test related, 25 which are doc related, 21 which are build / tool
related and 3 commits which are updates to dependencies.

Notable Changes:

* build:
 - Codesigning is fixed on macOS (Evan Lucas)
   #14179
* deps:
 - Snapshots are turned back on!!! (Yang Guo)
   #14385
* path:
 - win32 volume-relative paths are working again! (Timothy Gu)
   #14440
* tools:
 - v6.x can now build with ICU 59 (Steven R. Loomis)
   #12078

PR-URL: #14852

antoine-amara pushed a commit to antoine-amara/node that referenced this pull request Sep 7, 2017

2017-09-05, Version 6.11.3 'Boron' (LTS)
This LTS release comes with 152 commits. This includes 75 which are
test related, 25 which are doc related, 21 which are build / tool
related and 3 commits which are updates to dependencies.

Notable Changes:

* build:
 - Codesigning is fixed on macOS (Evan Lucas)
   nodejs#14179
* deps:
 - Snapshots are turned back on!!! (Yang Guo)
   nodejs#14385
* path:
 - win32 volume-relative paths are working again! (Timothy Gu)
   nodejs#14440
* tools:
 - v6.x can now build with ICU 59 (Steven R. Loomis)
   nodejs#12078

PR-URL: nodejs#14852

addaleax added a commit to addaleax/node that referenced this pull request Sep 13, 2017

2017-09-05, Version 6.11.3 'Boron' (LTS)
This LTS release comes with 152 commits. This includes 75 which are
test related, 25 which are doc related, 21 which are build / tool
related and 3 commits which are updates to dependencies.

Notable Changes:

* build:
 - Codesigning is fixed on macOS (Evan Lucas)
   nodejs#14179
* deps:
 - Snapshots are turned back on!!! (Yang Guo)
   nodejs#14385
* path:
 - win32 volume-relative paths are working again! (Timothy Gu)
   nodejs#14440
* tools:
 - v6.x can now build with ICU 59 (Steven R. Loomis)
   nodejs#12078

PR-URL: nodejs#14852
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment