Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

errors: add space between error name and code #12099

Closed
wants to merge 1 commit into from

Conversation

@jasnell
Copy link
Member

commented Mar 28, 2017

Error[CODE] becomes Error [CODE]

Depends on: #11220

/cc @Trott @evanlucas

(I'm not sure how to classify this on the semver scale since we have not actually used it yet)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

errors

errors: add space between error name and code
`Error[CODE]` becomes `Error [CODE]`

@jasnell jasnell requested review from evanlucas and Trott Mar 28, 2017

@Trott
Trott approved these changes Mar 28, 2017
Copy link
Member

left a comment

LGTM.

@gibfahn

This comment has been minimized.

Copy link
Member

commented Mar 28, 2017

(I'm not sure how to classify this on the semver scale since we have not actually used it yet)

seems like a semver-patch then.

@lpinca
lpinca approved these changes Mar 29, 2017
@evanlucas
Copy link
Member

left a comment

I feel like this is better. Thanks!

@addaleax addaleax added this to the 8.0.0 milestone Mar 31, 2017

@addaleax

This comment has been minimized.

jasnell added a commit that referenced this pull request Apr 3, 2017
errors: add space between error name and code
`Error[CODE]` becomes `Error [CODE]`

PR-URL: #12099
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Evan Lucas <evanlucas@me.com>
@jasnell

This comment has been minimized.

Copy link
Member Author

commented Apr 3, 2017

Landed in 7b4a72d

@jasnell jasnell closed this Apr 3, 2017

@jasnell jasnell referenced this pull request Apr 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.