Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: add .FromJust(), fix -Wunused-result warnings #12118

Closed

Conversation

@bnoordhuis
Copy link
Member

commented Mar 29, 2017

Missed while reviewing 1fde98b ("v8: expose new V8 serialization API.")

src: add .FromJust(), fix -Wunused-result warnings
Missed while reviewing 1fde98b ("v8: expose new V8 serialization API.")
@targos
targos approved these changes Mar 29, 2017
@danbev
danbev approved these changes Mar 29, 2017
@addaleax

This comment has been minimized.

Copy link
Member

commented Mar 31, 2017

Landed in 7c0079f

@addaleax addaleax closed this Mar 31, 2017

addaleax added a commit that referenced this pull request Mar 31, 2017
src: add .FromJust(), fix -Wunused-result warnings
Missed while reviewing 1fde98b ("v8: expose new V8 serialization API.")

PR-URL: #12118
Refs: #11048
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@jasnell jasnell referenced this pull request Apr 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
9 participants
You can’t perform that action at this time.