Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: Update trace event macros to V8 5.7 version #12127

Closed
wants to merge 1 commit into from

Conversation

@matthewloring
Copy link
Contributor

commented Mar 29, 2017

src/tracing/trace_event.h was updated by applying the following changes:

  1. Include src/tracing/trace_event_common.h instead of the one from v8
    base.

  2. Replace all instances of base::Atomic with intptr_t (trace events can
    only be generated from the main thread for now).

  3. Replace instances of V8_INLINE with inline.

  4. Eliminate uses of DCHECK.

  5. Eliminate uses of V8_UNLIKELY, the branch predictor should be good
    enough alone.

  6. Change the namespace used by trace_event.h from v8::internal::tracing
    to node::tracing.

  7. Remove CallStatsScopedTracer class and related macros (they rely on
    V8 implementation details).

  8. Change ConvertableToTraceFormat to v8::ConvertableToTraceFormat.

  9. Add function "static void SetCurrentPlatform(v8::Platform*
    platform);" to the declaration of TraceEventHelper.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src, tracing

Matt Loring
src: Update trace event macros to V8 5.7 version
src/tracing/trace_event.h was updated by applying the following changes:

1) Include src/tracing/trace_event_common.h instead of the one from v8
base.

2) Replace all instances of base::Atomic with intptr_t (trace events can
only be generated from the main thread for now).

3) Replace instances of V8_INLINE with inline.

4) Eliminate uses of DCHECK.

5) Eliminate uses of V8_UNLIKELY, the branch predictor should be good
enough alone.

6) Change the namespace used by trace_event.h from v8::internal::tracing
to node::tracing.

7) Remove CallStatsScopedTracer class and related macros (they rely on
V8 implementation details).

8) Change ConvertableToTraceFormat to v8::ConvertableToTraceFormat.

9) Add function "static void SetCurrentPlatform(v8::Platform*
platform);" to the declaration of TraceEventHelper.
@matthewloring

This comment has been minimized.

Copy link
Contributor Author

commented Mar 29, 2017

@joshgav

This comment has been minimized.

Copy link
Member

commented Mar 29, 2017

haven't reviewed the code yet really, but can confirm it does track AsyncWrap objects with joshgav@fda406f. Thanks @matthewloring!

@matthewloring

This comment has been minimized.

Copy link
Contributor Author

commented Apr 3, 2017

@nodejs/v8 to review

@ofrobots
Copy link
Contributor

left a comment

Rubberstamp LGTM

@matthewloring

This comment has been minimized.

Copy link
Contributor Author

commented Apr 5, 2017

@matthewloring

This comment has been minimized.

Copy link
Contributor Author

commented Apr 5, 2017

CI is green

@matthewloring

This comment has been minimized.

Copy link
Contributor Author

commented Apr 5, 2017

Landed in ebeee85

@jasnell jasnell referenced this pull request May 11, 2017
@matthewloring matthewloring referenced this pull request Sep 21, 2017
3 of 3 tasks complete
hferreiro added a commit to brave/node that referenced this pull request Sep 27, 2017
src: Update trace event macros to V8 5.7 version
src/tracing/trace_event.h was updated by applying the following changes:

1) Include src/tracing/trace_event_common.h instead of the one from v8
base.

2) Replace all instances of base::Atomic with intptr_t (trace events can
only be generated from the main thread for now).

3) Replace instances of V8_INLINE with inline.

4) Eliminate uses of DCHECK.

5) Eliminate uses of V8_UNLIKELY, the branch predictor should be good
enough alone.

6) Change the namespace used by trace_event.h from v8::internal::tracing
to node::tracing.

7) Remove CallStatsScopedTracer class and related macros (they rely on
V8 implementation details).

8) Change ConvertableToTraceFormat to v8::ConvertableToTraceFormat.

9) Add function "static void SetCurrentPlatform(v8::Platform*
platform);" to the declaration of TraceEventHelper.

PR-URL: nodejs/node#12127
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.